Left menu does not contain virtual server related stuff about authentic-theme HOT 26 CLOSED

When I logging as master user I see this:

Could you please login is master user (root) in Webmin and see if you get the menu? If you do, I will confirm this as a bug and will try to fix it in next releases.

from authentic-theme.

Exactly.
Basically, what is missing is this:

However I am not even sure this is a bug, since all the links missing in the menu are shown on the right page in your theme... maybe this is default webmin behavior, I have no idea.
Maybe some guy from the Webmin/Virtualmin team can give more insight :)

from authentic-theme.

Now I see. I will try fixing single user mode, when I have time - I will fix it most likely, just not right now.

I will keep the ticket open until I solve it.

Thanks for pointing out.

from authentic-theme.

Ohh.. Just looked through the amount of additional work for that stuff.. :) I will keep it in mind and will try to accomplish it sooner or later but definitely not in next few releases. It's a lot to test and do.

Will keep the ticket open until I get my final decision/solution.

from authentic-theme.

Hi. I just installed this theme and it looks great but ... I can't find the section that allows access to the 'Services' section of each virtual server.

from authentic-theme.

Interesting. Can you find it in right side menus, after clicking on desired domain name, right under Server Configuration header, there is a bunch of buttons?

from authentic-theme.

I'll take a look and let you know.
On 31/10/2014 5:32 pm, "Ilia Rostovtsev" [email protected] wrote:

Interesting. Can you find it in right side menus, after clicking on
desired domain name, right under Server Configuration header, there is a
bunch of buttons?

—
Reply to this email directly or view it on GitHub
#7 (comment).

from authentic-theme.

I've had another look at the Virtualmin menus (with the latest theme update).
Image 1 is the bottom of the authentic theme virtual server config section and image 2 is the menu from the default virutalmin template. Everything below 'Disable Virtual Server' is missing.

from authentic-theme.

These are Virtualmin Pro functions, I suppose. I will keep the ticket open until I find the solution.

Thanks for reporting.

from authentic-theme.

I don't have a pro version... This is the standard version.
On 03/11/2014 7:43 pm, "Ilia Rostovtsev" [email protected] wrote:

These are Virtualmin Pro functions, I suppose. I will keep the ticket open
until I find the solution.

Thanks for reporting.

—
Reply to this email directly or view it on GitHub
#7 (comment).

from authentic-theme.

Alright, understood. Will take a look.

from authentic-theme.

About populating the left menu with the same content that is on the right side - no, unfortunately (or fortunately) I will not be able to do this. That would be a lot of work to do and for absolutely no particular/practical reason, as all of links can be found on the right side.

However, there are some missing parts and this is strictly Virtualmin module oversight. By nature all of the permitted sections/links must be processed and printed by module itself but not by theme. Doing it by the theme (what is actually done with default Virtualmin Framed Theme) is totally wrong. I could understand why Joe did that but this must be fixed by Virtualmin Inc. team as it's strictly necessary to separate logic and presentation.

I disagree with having any kind of logic in the theme, as it will create additional mess and make future support more and more problematic.

I will notify Virtualmin Inc., so you do the same, and probably Joe will be able to add missing, permission dependent content, to the module itself and it will be eventually displayed on the right side.

A lot of things fixed/implemented in version 6.0.0! Please update.

I hope you will like it.

Regards,
Ilia

from authentic-theme.

I agree this should be in the Virtualmin module, rather than generated by the theme. I'll talk to Jamie about getting that done. We did roll some of this stuff down into functions in Virtualmin rather than in the theme, in the past (the left-hand menus used to be pretty much entirely generated by the theme). But, nothing related to permissions should be in the theme, at all, as it makes it too easy for security problems to pop up in themes that don't do it right. And, of course, this explodes the difficulty of making a theme, since it requires intimate knowledge of Virtualmin internals.

from authentic-theme.

Thank you, my friend!

from authentic-theme.

Right side is still missing some logging modules. AWstats, Webalizer, Apache Error/Access Log.
Bandwidth graph is ok

from authentic-theme.

Yes, swelljoe is a developer of Virtualmin. They promised to take a look and only they can/should fix it. Please read the comments above.

from authentic-theme.

ok. I'm sorry. misread.

from authentic-theme.

Just an update on this, Jamie is working on it. Sounds like there will be a single function to find out which menus to render (i.e. Webmin, Virtualmin, Cloudmin, maybe other menus in the future), and then you'll be able to request a data structure containing everything that should appear in that menu (probably an array of hashes or similar). We'll also have a function you can copy into your theme to render it to HTML, if you don't want to deal with the Perl data structure processing stuff. I don't know when this will be finished (it's pretty big), but Jamie works incredibly fast once he starts in on something. I'd be surprised if we don't have something within the next week or two.

I'll eventually push a ui-lib.pl function that'll render menus with little to no Perl code needed. That'll happen in Webmin 2.0, when we're able to break backward compatibility for themes and modules.

from authentic-theme.

That sounds like a good news! ;)

What about the right side, will Virtualmin be able to render Services, Logs and reports and some other hardcoded to Virtualmin Framed Theme options?

from authentic-theme.

Yes, as I understand it, all of the menu functionality currently found in virtual-server-theme in left.cgi will be moved into a few function calls in virtual-server. I'm not sure exactly what Jamie will come up with, but I'll check in with him about it today at the company meeting. There's other stuff in the theme that ought to be pushed down, as well, but we'll cross those bridges as we come to them, and it doesn't seem like they have caused you too much trouble implementing them (since you have the functionality working, I think, in your theme...like configuration of what gets displayed on the dashboard; I'd written a dashboard module in the past that pushed all of those details down out of the theme, but never made it part of core Webmin, but will update that module and do so in the coming weeks).

Jamie and I have somewhat different opinions of how much Perl should be visible to theme designers; Jamie wants everything to be customizable at the theme level (which makes sense if everything is hard-coded in HTML and tables and such, as Webmin currently is), but I'd like to see a Webmin that can be entirely themed with only HTML, CSS, and JavaScript; and possibly a JavaScript template language. We'll end up somewhere in the middle for Webmin 2.0.

from authentic-theme.

I will keep track for upcoming changes!

Thanks, Joe!

from authentic-theme.

... and having some access to the Perl is good. Besides, it's going to be endlessly difficult for Jamie to make such complete functionality without any access to Perl from the theme side. No, Perl is good. I just stand for that functionality of modules itself, is kept separate from themes.

I can hardly imagine how much work should be done/re-done to accomplish things in pure HTML, CSS, and JavaScript, not even sure if that is hardly possible.

from authentic-theme.

I've implemented a new function in Webmin 1.720 that theme authors can call to get a list of left-menu items requested by Virtualmin or Cloudmin - see https://github.com/webmin/webmin/blob/master/web-lib-funcs.pl#L10037

An example use of this will be in the next release of virtual-server-theme , and data will be provided for it in the next release of Virtualmin.

from authentic-theme.

Alright, Jamie, I will take a look, when it's out.

Thank you for your work.

from authentic-theme.

hope soon... also new lang implementation REALLY needed! lol
anyway, logs are important...is not easy to manually manage them, above all when many domains...

thank you!!! ;-)

from authentic-theme.

Support for the left menu, will be added in version 9.0 for all users with Webmin 1.730+.
Thanks.

from authentic-theme.