Giter Club home page Giter Club logo

Comments (8)

mkaply avatar mkaply commented on May 28, 2024

This is easy to fix.

Did any other abouts work?

Do you want any other abouts to work?

from webconverger-addon.

kaihendry avatar kaihendry commented on May 28, 2024

about:certerror, about:neterror, about: & about:blank seem like a fine subset. Unless I'm missing something ? :)

from webconverger-addon.

kaihendry avatar kaihendry commented on May 28, 2024

Hmmm, I just tried accessing some other about: pages from about: and these work:

  • about:buildconfig
  • about:credits
  • about:license

Er, is this right? I expected a explicit whitelist here and didn't expect these to work! :}

from webconverger-addon.

mkaply avatar mkaply commented on May 28, 2024

I must have done something wrong. I'll check.

from webconverger-addon.

kaihendry avatar kaihendry commented on May 28, 2024

Just to clear, I think we should whitelist:

  • about:certerror
  • about:neterror
  • about: ← important for users to see Webconverger version
  • about:blank
  • about:buildconfig
  • about:credits
  • about:license

But not about:ImadeTHISup ;)

from webconverger-addon.

mkaply avatar mkaply commented on May 28, 2024

You added about: as a .test, so every URL matches that.

for allowing about:, it needs to be a aContentLocation.spec == "about:"

from webconverger-addon.

kaihendry avatar kaihendry commented on May 28, 2024

Oops, maybe I should revert my stupid change? And do a I force update?

from webconverger-addon.

mkaply avatar mkaply commented on May 28, 2024

Don't worry about it. I've got a new patch coming.

#29

from webconverger-addon.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.