[SPEC] missing Π-mod ZK-proof about cggmp-threshold-ecdsa HOT 3 OPEN

Hmm, I think the check is done transitively in FS-DKR. Here we create NiCorrectKeyProof which seems to be implementing https://eprint.iacr.org/2018/057.pdf. CGGMP paper defines PI-mod to be a simplification of 2018/057.

On closer inspection, I agree, it's also checked in GG20.

So for this Fireblocks report, it looks like its only the Lindell17 implementation for multi-party-ecdsa that was vulnerable to this attack https://www.fireblocks.com/blog/lindell17-abort-vulnerability-technical-report?

On closer look again, I think it's vulnerable since this check is not for the auxiliary modulus $\tilde N$

from cggmp-threshold-ecdsa.

@ivokub I think we should implement it, the attack you linked is essentially an unpatched vulnerability for both this library and multi-party-ecdsa.

@drewstone I remember there was some kind of plan to patch it on your side (possibly for another repo if I remember correctly), not sure if that was done already and we can just pull it in?

from cggmp-threshold-ecdsa.

Hmm, I think the check is done transitively in FS-DKR. Here we create NiCorrectKeyProof which seems to be implementing https://eprint.iacr.org/2018/057.pdf. CGGMP paper defines PI-mod to be a simplification of 2018/057.

from cggmp-threshold-ecdsa.