Comments (7)
Locking the unit to 64k would prevent us from changing the page size constraints in the future (there are some mentions of this in the design repo). So I think it probably needs to be in bytes.
from spec.
It was already decided to have just one page size and go with that. There is/was consensus to change the v8 encoding to units of the pages size, and less significant bits are just noise in the wast and a challenge to define how they map to the binary encoding? Happy to close this as it is just a wast suggestion and the deployment encoding is going to page sized units.
from spec.
Give up on this, keeping them as bytes. There are spec tests imported into other tools such as sexpr-wasm-prototype that would require coordination.
from spec.
The point of the wasm page size constant is to not change in the future (after v.1). We have discussed that in the future modules could optionally declare a bigger (multiple) of page size in the memory section and then the page-count would, I assume, be interpreted as a count of the declared page size. This would all be backwards-compatible, though, since the bigger page size was opt-in.
So since the binary format is being changed to use units of pages, I'd recommend doing the same for the text format.
from spec.
Could this be closed now?
from spec.
It seems to still be the case that memory_size
and grow_memory
return units of bytes.
from spec.
Fixed a while ago.
from spec.
Related Issues (20)
- The definition of validation of br_table is inadequate HOT 3
- Question about validation of {element, data} segments HOT 1
- Wrong test cases in memory_init.wast HOT 3
- test case `as-load-operand` have an error HOT 1
- branching on function name HOT 7
- [interpreter] Source locations are broken since menhir switch HOT 2
- SIMD test optimization? HOT 3
- [core] SIMD Compare instructions link to the wrong "execution"/"validation" sections HOT 1
- Add a note indicating that section ids and section ordering do not correspond HOT 2
- Missing ability to access built older versions of the WebAssembly specification in archivable form HOT 2
- Web HOT 1
- [JS API] 'run a host function' and 'create a host function' don't consistently handle completion records HOT 1
- Wording of README in proposals directory is misleading. HOT 6
- Test extreme alignments HOT 2
- Tests seem to cause side effects that other tests depend on HOT 2
- A question about max table size HOT 5
- Time to delete the old `master` branches? HOT 5
- Missing LICENSE file in the document directory HOT 1
- A question about the order of exports HOT 4
- [bikeshed] Some potential issues in js-api spec HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from spec.