Giter Club home page Giter Club logo

Comments (7)

kg avatar kg commented on August 12, 2024

Locking the unit to 64k would prevent us from changing the page size constraints in the future (there are some mentions of this in the design repo). So I think it probably needs to be in bytes.

from spec.

 avatar commented on August 12, 2024

It was already decided to have just one page size and go with that. There is/was consensus to change the v8 encoding to units of the pages size, and less significant bits are just noise in the wast and a challenge to define how they map to the binary encoding? Happy to close this as it is just a wast suggestion and the deployment encoding is going to page sized units.

from spec.

 avatar commented on August 12, 2024

Give up on this, keeping them as bytes. There are spec tests imported into other tools such as sexpr-wasm-prototype that would require coordination.

from spec.

lukewagner avatar lukewagner commented on August 12, 2024

The point of the wasm page size constant is to not change in the future (after v.1). We have discussed that in the future modules could optionally declare a bigger (multiple) of page size in the memory section and then the page-count would, I assume, be interpreted as a count of the declared page size. This would all be backwards-compatible, though, since the bigger page size was opt-in.

So since the binary format is being changed to use units of pages, I'd recommend doing the same for the text format.

from spec.

 avatar commented on August 12, 2024

Could this be closed now?

from spec.

lukewagner avatar lukewagner commented on August 12, 2024

It seems to still be the case that memory_size and grow_memory return units of bytes.

from spec.

rossberg avatar rossberg commented on August 12, 2024

Fixed a while ago.

from spec.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.