Comments (7)
The evaluator always ignores alignment. The intention is that None
means "no hint" and therefore natural alignment. But I guess I can see confusion with None
meaning "completely unaligned" (i.e., align=1
), so it'd be just as well to remove the option
and make align
an int
that parser.mly
fills in when missing.
from spec.
Plus we should perhaps define this in the design no? I looked quickly and did not see much information about the lack of information on alignment and what it implied.
from spec.
If we keep alignment an option
, then yes, it'd make sense for AstSemantics.md to say the hint is optional and, when not present, natural alignment should be assumed. If the alignment is changed to a non-optional
int, then it's a syntactic sugar detail of the sexpr language that the align
immediate is optional.
from spec.
Seems bizarre to me to say that we have to do align for a load but the immediate is optional.
(i32.load align (i32.const 0)) seems just overkill. I really think that the default should be that it is optional and if not there, it is defined in the AstSemantics.md as then meaning the load is of natural alignment.
from spec.
I think Luke was suggesting that the hint missing means that the access is
assumed to be aligned.
So:
(i32.load (i32.const 0))
and
(i32.load unaligned (i32.const 1))
?
On Tue, Nov 3, 2015 at 6:52 AM, jcbeyler [email protected] wrote:
Seems bizarre to me to say that we have to do align for a load but the
immediate is optional.(i32.load align (i32.const 0)) seems just overkill. I really think that
the default should be that it is optional and if not there, it is defined
in the AstSemantics.md as then meaning the load is of natural alignment.—
Reply to this email directly or view it on GitHub
#158 (comment).
from spec.
The s-expr language offers a variety of syntactic sugar wherein you can omit things and the obvious default AST node is generated. Having a missing align
attribute imply natural alignment seems to be no different. Thus, (i32.load (i32.const 0))
would imply align=4
. From AstSemantics.md POV (as it is currently written), there is always an alignment immediate, so no need to say what the default is. However, as I said above, we could change AstSemantics.md to say "alignment is optional, when missing natural alignment is assumed". I think it's all just a matter of subjective preference until we get to the binary encoding.
from spec.
This has been resolved.
from spec.
Related Issues (20)
- The definition of validation of br_table is inadequate HOT 3
- Question about validation of {element, data} segments HOT 1
- Wrong test cases in memory_init.wast HOT 3
- test case `as-load-operand` have an error HOT 1
- branching on function name HOT 7
- [interpreter] Source locations are broken since menhir switch HOT 2
- SIMD test optimization? HOT 3
- [core] SIMD Compare instructions link to the wrong "execution"/"validation" sections HOT 1
- Add a note indicating that section ids and section ordering do not correspond HOT 2
- Missing ability to access built older versions of the WebAssembly specification in archivable form HOT 2
- Web HOT 1
- [JS API] 'run a host function' and 'create a host function' don't consistently handle completion records HOT 1
- Wording of README in proposals directory is misleading. HOT 6
- Test extreme alignments HOT 2
- Tests seem to cause side effects that other tests depend on HOT 2
- A question about max table size HOT 5
- Time to delete the old `master` branches? HOT 5
- Missing LICENSE file in the document directory HOT 1
- A question about the order of exports HOT 4
- [bikeshed] Some potential issues in js-api spec HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from spec.