CFGWalker with Single-thread failed about binaryen HOT 4 OPEN

In general we do not reset such global state in those classes. Typically they are used with isFunctionParallel = true in which case a new instance is created each time (even in a single-threaded build, we should be creating new instances even if they do not actually run in parallel, for compatibility).

If you use them in a non-parallel way then I can see how there would be a problem, and this is in cfg-walker.h so it does imply that all users should be aware of this, which is kind of annoying, sorry about that. To improve this perhaps we could mark the class as function-parallel, though we'd need to check if we have any other uses in the codebase.

Alternatively we could reset those fields, but that would just add code size and work for a situation that function-parallel code is meant to avoid, so I'd lean against that.

from binaryen.