Comments (4)
Sure, we can run it occasionally.
from scope.
It seems to highlight a few times when we don't check the err:
vagrant@ubuntu-14:~/src/github.com/weaveworks/scope$ errcheck github.com/weaveworks/scope/app
github.com/weaveworks/scope/app/api_topology.go:62:14 r.ParseForm()
github.com/weaveworks/scope/app/api_topology.go:122:18 defer conn.Close()
github.com/weaveworks/scope/app/api_topology.go:143:24 conn.SetWriteDeadline(time.Now().Add(websocketTimeout))
github.com/weaveworks/scope/app/api_topology_test.go:134:16 defer ws.Close()
github.com/weaveworks/scope/app/main.go:46:16 defer w.Close()
github.com/weaveworks/scope/app/main.go:56:16 defer f.Close()
github.com/weaveworks/scope/app/main.go:66:18 defer os.Remove(*pidfile)
github.com/weaveworks/scope/app/scope_test.go:63:16 res.Body.Close()
github.com/weaveworks/scope/app/server_helpers.go:12:27 json.NewEncoder(w).Encode(response)
vagrant@ubuntu-14:~/src/github.com/weaveworks/scope$ errcheck github.com/weaveworks/scope/probe
github.com/weaveworks/scope/probe/main.go:56:25 go http.ListenAndServe(*httpListen, nil)
github.com/weaveworks/scope/probe/process_mapper.go:74:10 fh.Close()
github.com/weaveworks/scope/probe/process_mapper.go:113:10 f.Close()
github.com/weaveworks/scope/probe/process_mapper_test.go:20:20 defer os.RemoveAll(tmp)
github.com/weaveworks/scope/probe/process_mapper_test.go:47:16 os.RemoveAll(tmp)
github.com/weaveworks/scope/probe/process_mapper_test.go:52:16 os.RemoveAll(tmp)
from scope.
You can filter out close, which it seems pretty safe to ignore:
vagrant@ubuntu-14:~/src/github.com/weaveworks/scope$ errcheck -ignore 'Close' github.com/weaveworks/scope/app
github.com/weaveworks/scope/app/api_topology.go:62:14 r.ParseForm()
github.com/weaveworks/scope/app/api_topology.go:143:24 conn.SetWriteDeadline(time.Now().Add(websocketTimeout))
github.com/weaveworks/scope/app/main.go:66:18 defer os.Remove(*pidfile)
github.com/weaveworks/scope/app/server_helpers.go:12:27 json.NewEncoder(w).Encode(response)
from scope.
All of those are effectively harmless. But, I'm happy to throw in some checks. (And remove that pidfile stuff altogether.)
from scope.
Related Issues (20)
- weavescope after installing on openshift cluster not showing container and process details. HOT 2
- codahale/hdrhistogram repo url has been transferred under the github HdrHstogram umbrella
- Instructions do not work on an M1 mac
- How to run Weave Scope in Docker-compose? HOT 2
- What is a Safe way to run weave scope on GKE
- TeamTVT issue solved?
- Will Weaveworks scope support containerd for fetching container logs, k8s > 1.23 HOT 4
- Weavescope provides email notification? Is there a plugin for this.
- does it support upgrading k8s to 1.18.0-1.22.4?
- Release of scope-backend-build docker image HOT 6
- The app can't display kubernetes pods and other information
- Weave scope installed on KubeSpray v1.19'ed CRI cluster not showing any info / CRI example returns errors
- i18n support HOT 4
- How can update or upgrade docker instance for scope or git pull?
- More detail about graph mode
- how we run scope containerd ?
- There is no access restrictions when accessing weave-app by default HOT 1
- Pod status information such as memory and CPU not showing HOT 1
- Unable to display lines between containers in topology view
- Project dead? HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from scope.