Comments (2)
I know you're aware of this because of your thumbs up on my comment in the PHP7 support PR but for completeness' sake, please check that you agree to your changes being distributed under this package's dual licensing model.
I'm absolutely fine with it. Btw I like your dual licensing model a lot and consider to use it maybe in the future for my projects as well. (Also btw.: Maybe it's nice to link the GNU License in the README.md
with https://choosealicense.com/licenses/agpl-3.0/ for an easy overview)
Related; I'm playing with the idea of changing the naming from dataprovider to datasource since providers in Laravel apps are generally service providers and not data providers, if you have any thoughts on that naming / architectural issue I'd be happy to hear them, too.
Actually I like the DataProvider
naming convention because it feels like the laravel way of naming it, altough most of the times ServiceProvider
s are used. But I don't think that it is misleading or a naming issue in this case.
I associate a DataSource
to different things like external databases, queues, local directories or external APIs and that's not the case here.
Within the CalendarDataProvider.php
I have to provide the data for the calendar tool.
It's a good name, let's stick with it! ;-)
from nova-calendar.
HI @Lednerb, good point, thanks for your input!
I agree to the change and will accept the PR.
Maybe nova-calendar:create-default-data-provider
would be even better since the nova-calendar
prefix already indicates what it's for and I don't expect the calendar to have any non-calendar data providers anytime soon ;)
I know you're aware of this because of your thumbs up on my comment in the PHP7 support PR but for completeness' sake, please check that you agree to your changes being distributed under this package's dual licensing model.
Related; I'm playing with the idea of changing the naming from dataprovider to datasource since providers in Laravel apps are generally service providers and not data providers, if you have any thoughts on that naming / architectural issue I'd be happy to hear them, too.
Thanks for helping!
from nova-calendar.
Related Issues (20)
- Applying styles to calendar cells (for example to highlight current day and fade-out days in the past) HOT 3
- Allow us to include html inside the event notes HOT 2
- Please allow CMD/Meta/Ctrl click to open in a new tab when clicking on an event HOT 3
- Customizing Event properties in custom event generator HOT 3
- Poor performance - eager loading breaks in Custom Event Generators HOT 1
- recommendation: calendar backend library vkurko/calendar
- ERROR There are no commands defined in the "nova-calendar" namespace. HOT 2
- calendar does not load - missing slash in api url HOT 7
- Week View Update? HOT 1
- [Bug] Method Laravel\Nova\Http\Requests\NovaRequest::schemeAndHttpHost does not exist HOT 7
- When searching, events are still clickable HOT 7
- month and year pickers disappear on press HOT 3
- BindingResolutionException: Target class [] does not exist. when caching routes HOT 4
- Ability to use url parameters for optionally filtering down HOT 11
- It is possible to change the URL by clicking the event to access a custom tool instead of using the resource? HOT 3
- Style problems HOT 6
- How can I add the calendar to my Main.php dashboard? HOT 1
- Vue warning DropdownTrigger HOT 4
- Cannot change url by method `withUrl()`, when events are created by generator HOT 3
- Status of day view, week view, ... HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nova-calendar.