Support for env.valueFrom using configMapKeyRef and secretKeyRef about wave HOT 5 CLOSED

You're right, Wave should definitely include support for these! I completely missed this when doing the original implementation

At present, when parsing we just hash the whole configmap/secret for simplicity's sake, so I'd be tempted to start with a PR to add the parsing of the envVar section and just adding the whole secret/configmap (as we do with other sources) and then follow up with a second PR which makes the changes to only hash the individual keys within the secrets and configmaps.

WDYT?

from wave.

That's a possibility, yes, and I might be able to whip up a quick PR, but for our use case we'd want the final behaviour of spotting individual key changes.

I'm really close to finishing the code that handles specific keyed items: I've just got to handle the optional field and those fields being potentially missing (and extend the unit tests for that situation).

from wave.

PR submitted (#34) that includes the env section, only using the specified keys in the hash, and handling the optional flag as best I can.

from wave.

@andyedwardsdfdl Can this issue be closed now #34 is merged?

from wave.

Yep, I believe this is now resolved, and ready to go into the next release.

from wave.