Giter Club home page Giter Club logo

Comments (7)

Hywan avatar Hywan commented on July 18, 2024 3

Thanks for reporting the issue. I'll take a look at it.

from wasmer-php.

sc0Vu avatar sc0Vu commented on July 18, 2024 1

I can build with php 7.4.0 but not php 8.0.0.

The error message shown:

wasmer-php/src/wasm.cc:718:10: error: 
      no member named 'no_separation' in '_zend_fcall_info'
    fci->no_separation = 0;
    ~~~  ^
wasmer-php/src/wasm.cc:859:35: error: 
      no member named 'pass_by_reference' in
      '_zend_arg_info'
                if (argument_info.pass_by_reference) {
                    ~~~~~~~~~~~~~ ^
wasmer-php/src/wasm.cc:877:42: error: 
      use of undeclared identifier 'ZEND_TYPE_CODE'
                uint32_t argument_type = ZEND_TYPE_...
                                         ^
wasmer-php/src/wasm.cc:927:40: error: 
      use of undeclared identifier 'ZEND_TYPE_CODE'
                uint32_t return_type = ZEND_TYPE_CO...
                                       ^
wasmer-php/src/wasm.cc:2510:79: error: 
      expected ')'
  ...= zend_register_internal_class(&class_entry TSRMLS_...
                                                 ^
wasmer-php/src/wasm.cc:2510:65: note: 
      to match this '('
  ...= zend_register_internal_class(&class_entry TSRMLS_...
                                   ^
wasmer-php/src/wasm.cc:2530:5: error: 
      expected ')'
    DECLARE_WASM_TYPED_ARRAY(WasmInt8Array, int8, 1);
    ^
wasmer-php/src/wasm.cc:2524:87: note: 
      expanded from macro 'DECLARE_WASM_TYPED_ARRAY'
  ...= zend_register_internal_class(&class_entry TSRMLS_...
                                                 ^
wasmer-php/src/wasm.cc:2530:5: note: 
      to match this '('
wasmer-php/src/wasm.cc:2524:73: note: 
      expanded from macro 'DECLARE_WASM_TYPED_ARRAY'
  ...= zend_register_internal_class(&class_entry TSRMLS_...
                                   ^
wasmer-php/src/wasm.cc:2530:5: error: 
      expected ')'
    DECLARE_WASM_TYPED_ARRAY(WasmInt8Array, int8, 1);
    ^
wasmer-php/src/wasm.cc:2527:65: note: 
      expanded from macro 'DECLARE_WASM_TYPED_ARRAY'
  ...TSRMLS_CC, 1, zend_ce_arrayaccess); \
     ^
wasmer-php/src/wasm.cc:2530:5: note: 
      to match this '('
wasmer-php/src/wasm.cc:2527:26: note: 
      expanded from macro 'DECLARE_WASM_TYPED_ARRAY'
    zend_class_implements(wasm_typed_array_##type##...
                         ^
wasmer-php/src/wasm.cc:2531:5: error: 
      expected ')'
    DECLARE_WASM_TYPED_ARRAY(WasmUint8Array, uint8, 1);
    ^
wasmer-php/src/wasm.cc:2524:87: note: 
      expanded from macro 'DECLARE_WASM_TYPED_ARRAY'
  ...= zend_register_internal_class(&class_entry TSRMLS_...
                                                 ^
wasmer-php/src/wasm.cc:2531:5: note: 
      to match this '('
wasmer-php/src/wasm.cc:2524:73: note: 
      expanded from macro 'DECLARE_WASM_TYPED_ARRAY'
  ...= zend_register_internal_class(&class_entry TSRMLS_...
                                   ^
wasmer-php/src/wasm.cc:2531:5: error: 
      expected ')'
    DECLARE_WASM_TYPED_ARRAY(WasmUint8Array, uint8, 1);
    ^
wasmer-php/src/wasm.cc:2527:65: note: 
      expanded from macro 'DECLARE_WASM_TYPED_ARRAY'
  ...TSRMLS_CC, 1, zend_ce_arrayaccess); \
     ^
wasmer-php/src/wasm.cc:2531:5: note: 
      to match this '('
wasmer-php/src/wasm.cc:2527:26: note: 
      expanded from macro 'DECLARE_WASM_TYPED_ARRAY'
    zend_class_implements(wasm_typed_array_##type##...
                         ^
wasmer-php/src/wasm.cc:2532:5: error: 
      expected ')'
    DECLARE_WASM_TYPED_ARRAY(WasmInt16Array, int16, 2);
    ^
wasmer-php/src/wasm.cc:2524:87: note: 
      expanded from macro 'DECLARE_WASM_TYPED_ARRAY'
  ...= zend_register_internal_class(&class_entry TSRMLS_...
                                                 ^
wasmer-php/src/wasm.cc:2532:5: note: 
      to match this '('
wasmer-php/src/wasm.cc:2524:73: note: 
      expanded from macro 'DECLARE_WASM_TYPED_ARRAY'
  ...= zend_register_internal_class(&class_entry TSRMLS_...
                                   ^
wasmer-php/src/wasm.cc:2532:5: error: 
      expected ')'
    DECLARE_WASM_TYPED_ARRAY(WasmInt16Array, int16, 2);
    ^
wasmer-php/src/wasm.cc:2527:65: note: 
      expanded from macro 'DECLARE_WASM_TYPED_ARRAY'
  ...TSRMLS_CC, 1, zend_ce_arrayaccess); \
     ^
wasmer-php/src/wasm.cc:2532:5: note: 
      to match this '('
wasmer-php/src/wasm.cc:2527:26: note: 
      expanded from macro 'DECLARE_WASM_TYPED_ARRAY'
    zend_class_implements(wasm_typed_array_##type##...
                         ^
wasmer-php/src/wasm.cc:2533:5: error: 
      expected ')'
    DECLARE_WASM_TYPED_ARRAY(WasmUint16Array, uint16, 2);
    ^
wasmer-php/src/wasm.cc:2524:87: note: 
      expanded from macro 'DECLARE_WASM_TYPED_ARRAY'
  ...= zend_register_internal_class(&class_entry TSRMLS_...
                                                 ^
wasmer-php/src/wasm.cc:2533:5: note: 
      to match this '('
wasmer-php/src/wasm.cc:2524:73: note: 
      expanded from macro 'DECLARE_WASM_TYPED_ARRAY'
  ...= zend_register_internal_class(&class_entry TSRMLS_...
                                   ^
wasmer-php/src/wasm.cc:2533:5: error: 
      expected ')'
    DECLARE_WASM_TYPED_ARRAY(WasmUint16Array, uint16, 2);
    ^
wasmer-php/src/wasm.cc:2527:65: note: 
      expanded from macro 'DECLARE_WASM_TYPED_ARRAY'
  ...TSRMLS_CC, 1, zend_ce_arrayaccess); \
     ^
wasmer-php/src/wasm.cc:2533:5: note: 
      to match this '('
wasmer-php/src/wasm.cc:2527:26: note: 
      expanded from macro 'DECLARE_WASM_TYPED_ARRAY'
    zend_class_implements(wasm_typed_array_##type##...
                         ^
wasmer-php/src/wasm.cc:2534:5: error: 
      expected ')'
    DECLARE_WASM_TYPED_ARRAY(WasmInt32Array, int32, 4);
    ^
wasmer-php/src/wasm.cc:2524:87: note: 
      expanded from macro 'DECLARE_WASM_TYPED_ARRAY'
  ...= zend_register_internal_class(&class_entry TSRMLS_...
                                                 ^
wasmer-php/src/wasm.cc:2534:5: note: 
      to match this '('
wasmer-php/src/wasm.cc:2524:73: note: 
      expanded from macro 'DECLARE_WASM_TYPED_ARRAY'
  ...= zend_register_internal_class(&class_entry TSRMLS_...
                                   ^
wasmer-php/src/wasm.cc:2534:5: error: 
      expected ')'
    DECLARE_WASM_TYPED_ARRAY(WasmInt32Array, int32, 4);
    ^
wasmer-php/src/wasm.cc:2527:65: note: 
      expanded from macro 'DECLARE_WASM_TYPED_ARRAY'
  ...TSRMLS_CC, 1, zend_ce_arrayaccess); \
     ^
wasmer-php/src/wasm.cc:2534:5: note: 
      to match this '('
wasmer-php/src/wasm.cc:2527:26: note: 
      expanded from macro 'DECLARE_WASM_TYPED_ARRAY'
    zend_class_implements(wasm_typed_array_##type##...
                         ^
wasmer-php/src/wasm.cc:2535:5: error: 
      expected ')'
    DECLARE_WASM_TYPED_ARRAY(WasmUint32Array, uint32, 4);
    ^
wasmer-php/src/wasm.cc:2524:87: note: 
      expanded from macro 'DECLARE_WASM_TYPED_ARRAY'
  ...= zend_register_internal_class(&class_entry TSRMLS_...
                                                 ^
wasmer-php/src/wasm.cc:2535:5: note: 
      to match this '('
wasmer-php/src/wasm.cc:2524:73: note: 
      expanded from macro 'DECLARE_WASM_TYPED_ARRAY'
  ...= zend_register_internal_class(&class_entry TSRMLS_...
                                   ^
wasmer-php/src/wasm.cc:2535:5: error: 
      expected ')'
    DECLARE_WASM_TYPED_ARRAY(WasmUint32Array, uint32, 4);
    ^
wasmer-php/src/wasm.cc:2527:65: note: 
      expanded from macro 'DECLARE_WASM_TYPED_ARRAY'
  ...TSRMLS_CC, 1, zend_ce_arrayaccess); \
     ^
wasmer-php/src/wasm.cc:2535:5: note: 
      to match this '('
wasmer-php/src/wasm.cc:2527:26: note: 
      expanded from macro 'DECLARE_WASM_TYPED_ARRAY'
    zend_class_implements(wasm_typed_array_##type##...
                         ^
17 errors generated.
make[1]: *** [wasm.lo] Error 1
make: *** [build] Error 2

from wasmer-php.

jubianchi avatar jubianchi commented on July 18, 2024 1

Hello @yerke

TBH, supporting both PHP8 and PHP7 requires some work but I'll try to fix that.

from wasmer-php.

leemcd56 avatar leemcd56 commented on July 18, 2024

Same occurs in PHP 8.0.0:

creating libtool
appending configuration tag "CXX" to libtool
configure: patching config.h.in
configure: creating ./config.status
config.status: creating config.h
running: make
/bin/sh /private/tmp/pear/temp/pear-build-nathanaelDGeYBa/wasm-0.5.0/libtool --mode=compile  -I. -I/private/tmp/pear/temp/wasm/src -I/private/tmp/pear/temp/pear-build-nathanaelDGeYBa/wasm-0.5.0/include -I/private/tmp/pear/temp/pear-build-nathanaelDGeYBa/wasm-0.5.0/main -I/private/tmp/pear/temp/wasm/src -I/usr/local/Cellar/php/8.0.0_1/include/php -I/usr/local/Cellar/php/8.0.0_1/include/php/main -I/usr/local/Cellar/php/8.0.0_1/include/php/TSRM -I/usr/local/Cellar/php/8.0.0_1/include/php/Zend -I/usr/local/Cellar/php/8.0.0_1/include/php/ext -I/usr/local/Cellar/php/8.0.0_1/include/php/ext/date/lib  -I/usr/local/opt/ruby/include -DHAVE_CONFIG_H      -c /private/tmp/pear/temp/wasm/src/wasm.cc -o wasm.lo
libtool: unrecognized option `-I.'
Try `libtool --help' for more information.
make: *** [wasm.lo] Error 1
ERROR: `make' failed

from wasmer-php.

Hywan avatar Hywan commented on July 18, 2024

This issue is now our priority :-). cc @wasmerio/langint

from wasmer-php.

jubianchi avatar jubianchi commented on July 18, 2024

Hello @edorian

As @Hywan said, wasmer-php is part of our current priorities. Is PHP7 still required for you?

For now, we only test and build with PHP8 but we can look at introducing support for PHP7.4.

from wasmer-php.

yerke avatar yerke commented on July 18, 2024

@jubianchi It would be nice to add support for PHP 7.4, if it's not too much trouble. There is still a lot of legacy code that will not be upgraded to 8.0 any time soon.
P.S. Thank you to the whole team for working on this project.

from wasmer-php.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.