perf: possible mem leak in v8.serialize() about warp HOT 8 CLOSED

fixed in #108, released in 0.4.36

from warp.

switch to https://developer.mozilla.org/en-US/docs/Web/API/structuredClone when it will be implemented by most of the browsers.

from warp.

👍🏻 Subscribing

from warp.

Performance comparison ("state evaluation" column) for "loot" contract:

1. @ungap/structured-clone

2. v8.deserialize(v8.serialize(input))

3. lodash/cloneDeep

4. JSON.parse(JSON.stringify(input, mapReplacer), mapReviver);

from warp.

Maybe I'm not reading the bench correctly, but isn't lodash more performant than ungap here?

from warp.

Maybe I'm not reading the bench correctly, but isn't lodash more performant than ungap here?

You're reading the bench correctly ;-) lodash indeed is more performant than ungap and v8 in this case. Though I believe that for "bigger" states - v8 was the winner. Anyway, I'll stick with lodash for now...

from warp.

Just a word of comment if anyone was interested - deepCopy-ing of the state is required for each interaction - before the state is passed to the contract's handler function. Contracts usually modify the state directly and without deepCopy - there would be risk of changing values somewhere in the host code (eg. values stored in cache).

v1 performed here simple stringify/parse https://github.com/ArweaveTeam/SmartWeave/blame/master/src/contract-step.ts#L56 - which obv. is least performant.

This won't be an issue in case of WASM contract - which store their state in the wasm module memory.

from warp.

Ah ok, I was confused with the commits being referenced using ungap, but they were probably old

🎉 Will try this

from warp.