refactor: `createTx()` overwrites user-provided Tag values with default values about warp HOT 5 CLOSED

PR with fix: #85

from warp.

Hmm, those "default" tags are part of the core SmartWeave protocol specification and I believe that they shouldn't be overwritten...so the statement that it makes the sdk unacceptalbe for production is a bit too strong IMO :-)
Anyway, I'll need to think about this feature for a while, thanks for posting the issue.

This is also the reason why the "tags" are described as "additional tags that can be attached to the newly created interaction transaction"

from warp.

@estill01 what is your exact use-case and why do you want to overwrite the default protocol tags?
The app-version tag is the SmartWeave protocol version and this one in particular should not be overwritten.
If you would overwrite the value of the app-name (e.g. SmartWeaveAction for interactions) - you wouldn't be able to load such interactions using the default mechanism specified by the protocol.

Keep in mind that this is also how the original sdk behaved - https://github.com/ArweaveTeam/SmartWeave/blob/master/src/contract-create.ts#L78

from warp.

@estill01 ?

from warp.

Closing due to lack of activity.

from warp.