Tests about container-image-csi-driver HOT 4 CLOSED

Nice question!

There are no unit tests currently because I think unit tests are only useful for those very complicated functions. There are no such functions so far in the project. For features, I prefer integration tests. Before merging each PR, I would run integration tests manually. A CI workflow to run integration tests would be great, but it needs K8s clusters with different container runtime, and I am not sure where I can found these clusters which can also be integrated into GitHub. And, we don't have so many contributors and PRs now, that running tests manually is acceptable.

Before starting the e2e tests, I would prepare a K8s cluster with the driver installed, then run make e2e. The instruction kubectl dev in the Makefile is used to build images. It can be replaced with docker. I am not sure if there are enough cases in the current e2e tests. It needs study and improvement.

Any contribution is welcome. Appreciate!

from container-image-csi-driver.

For testing the driver I would suggest you use k3s , this is a great and light K8s cluster that support both containerd and docker.
There is even a github action for it : https://github.com/marketplace/actions/actions-k3s
I have just tested the driver on it and it works like a charm, I'll propose a PR to provide the correct install manifest.

from container-image-csi-driver.

I confirm that I tested the driver with k3s using both containerd (using the proposed install script in #22) and docker as container runtime (using the cri-containerd.yaml ! install script) and they both work.

from container-image-csi-driver.

Thanks, @sgandon. I will give it a try.

from container-image-csi-driver.