Comments (4)
I assumed that GGIR uses the same code for both data formats.
-
I am only wondering now whether this recent commit is causing trouble by attempting to look for and impute gaps twice when
rmc.imputegaps = TRUE
. -
Could it be that the difference is in how you created the csv file? In GGIR the gt3x file is read with default read.gt3x arguments https://github.com/wadpac/GGIR/blob/master/R/g.readaccfile.R#L275-L276 and without using the imputezeros or clean options that read.gt3x offers.
-
The MVPA extraction happens much further down the line and is the same code for all data format. So, I think that differences must be explained by the raw data itself or by how it is read. It may be good to compare the output of read.myacc.csv() to read.gt3x() output:
- Do you see any obvious synchronisation problems when you plot the signals on top of each other, e.g. time zone difference?
- Are time series the same length?
Note that saving numeric data to csv can in itself introduce some tiny rounding errors.
If that does not lead to a clear explanation then we may need to try comparing the epoch level metrics produced by GGIR part 1 ... to get these load the .RData file form the output subfolder meta/basic
folder and inspect object M$metashort. These are the metric values.
from ggir.
@pinweichen have you tried running one of the data files where you see this issue through the latest version of GGIR?
I know you said you need GGIR 3.0-0 for your project, but there have been a few changes to raw data handling since last October when that version came out.
from ggir.
Thank you Lena and Vincent for responding.
To Vicent's questions:
- The duplicated steps of time gap imputation do not affect the result. The discrepancy results still exist when both rmc.imputegaps = FALSE and rmc.doresample = FALSE. I also was testing on GGIR 3.0-0.
2 & 3. I've compared all three types of raw data and compared them row by row: 1. load gt3x using default gt3x load method, 2. load my customized version of csv using fread, and 3. load the csv file using read.myacc.csv function from GGIR. All three data are identical when loaded. Time series are in the same length.
I also compared the part 1 meta result by loading the meta/basic file. I notice in C variable, the spheredata are different. So are the scale, and offset. (Original_C = gt3x result. std_C = custom csv result.)
I've also tested the version when I turned on rmc.imputegaps = TRUE and rmc.doresample = TRUE.
It seems like somewhere in the calibration steps creates these errors. Are those calibration steps for custom csv handled differently than the gt3x? Where can I dig more about the potential cause? I do have some header information missing since it didn't read directly from gt3x. What information in the header could be important for the calibration steps?
To Lena,
I haven't adapted the GGIR 3.1-2 version yet. I did make some changes in the read.myacc.csv header reading portion in my current pipeline. I will need to move those changes with the 3.1-2 version before I test the custom csv. However, I've tested the output from read.myacc.csv. It produces the same result as if I read the gt3x.
Thank you for your time and patience.
from ggir.
If you insist on using an older version of GGIR then you also have to life with all the bugs and inconsistencies it had.
If you want the issue to be fixed use the latest GGIR version.
If the issue is still present in the latest GGIR version then please clarify as this is currently unclear to me.
from ggir.
Related Issues (20)
- timegap imputation for ad-hoc csv not working?
- broaden range of optional values for parameter chunksize
- Option to specify or auto-detect desired order of sleep 'guider' methods to be used HOT 1
- Sleep efficiency calculation part 4 incorrectly uses guider instead of detect SPT window HOT 1
- Error in if (is.na(defaultGuiderOnset) == TRUE) { => Recording with 1 midnight that starts before 4am
- Minor bug in append records functionality
- Minimum sample frequency HOT 1
- daysleeper not working correctly when no sleeplog used
- Identification of nights and days to exclude in data_cleaning_File
- Add check that basic sleeplog as even number of columns
- Add folder with custom R scripts used by GGIR users
- Non-wear detection in the middle of the SPT window
- Replace visualreport by a report that aligns with the rest of GGIR HOT 1
- part3 plot error: seq.int(0, to0 - from, by) : 'to' must be a finite number
- Improve clipping (problematic data) detection
- part5 data dictionary generation errors when not part 5 output available
- 1:dummywake errors in part 5
- object 'DAYL5HOUR' not found" in part 2
- Error in as.POSIXlt.numeric(x) : 'origin' must be supplied (for older R versions) HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ggir.