Giter Club home page Giter Club logo

Comments (8)

SergeyKanzhelev avatar SergeyKanzhelev commented on July 29, 2024

We explained in PR why we need limit. We still haven't explained why the limit is 512

from trace-context.

SergeyKanzhelev avatar SergeyKanzhelev commented on July 29, 2024

So far asking different providers - everybody wants smaller limit, but have not upper-bound physical limitation that will prevent saving and propagation of 512 characters.

So we need to put rationaly of why we need 512. If you implemented tracestate - can you post example/size you need?

from trace-context.

SergeyKanzhelev avatar SergeyKanzhelev commented on July 29, 2024

For example, B3 encoding will require 72 characters tracestate: b3=80f198ee56343ba864fe8b2a57d3eff7-05e3ac9a4f6e3b90-1-e457b5a2e4d86bd1 (see: openzipkin/b3-propagation#21).

from trace-context.

yurishkuro avatar yurishkuro commented on July 29, 2024

I feel that any limit number is going to be largely arbitrary. We can instead clearly outline procedure for trimming the state and not specify a hard limit, or use an external one like limit for cookies.

from trace-context.

SergeyKanzhelev avatar SergeyKanzhelev commented on July 29, 2024

One thing I think we can avoid by defining some hard limit is abuse of the header to propagate user-defined baggage. If you know that it will be cut anyway - you'd look for solution like Correlation-Context from the beginning instead of frustration when context will not be propagated,

I like that idea though. Definitely good idea to detail the trimming procedure

from trace-context.

yurishkuro avatar yurishkuro commented on July 29, 2024

I just think the exact limit can be very application specific, e.g. an application that exchanges many small messages will be more sensitive to the header size than one that carries 20Kb JSON requests. So the exact limit might be configurable per application, but the spec's hard limit should be more generous, like the cookie size limit of 4093.

Let the market forces pressure vendors to keep the size to a minimum.

from trace-context.

discostu105 avatar discostu105 commented on July 29, 2024

Here is how the Dynatrace tracestate will likely (typically) look like:

fw5-29a-3039@dt=1;FEC354CD6;1;2;727c (36 bytes)

However, the elements are of variable length, so they could be longer. The theoretical maximum would be like this:

fw5-ffffffff-ffffffff@dt=ffffffff;ffffffffffffffff;ffffffff;ffffffff;ffffffff (77 bytes)

from trace-context.

SergeyKanzhelev avatar SergeyKanzhelev commented on July 29, 2024

Closing in favor of #239

from trace-context.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.