Giter Club home page Giter Club logo

Comments (4)

marcoscaceres avatar marcoscaceres commented on July 1, 2024

What happened to the rule that changes would only be done via PRs? Did that go away?

from mediasession.

foolip avatar foolip commented on July 1, 2024

Rich has been doing commit-then-review since the beginning of this spec. I'm happy with that, who would be doing the review of pull requests?

from mediasession.

marcoscaceres avatar marcoscaceres commented on July 1, 2024

On June 30, 2015 at 9:24:10 PM, Philip Jägenstedt ([email protected]) wrote:

Rich has been doing commit-then-review since the beginning of this spec. I'm happy with
that, who would be doing the review of pull requests?

I thought it would be you and others involved (i.e., to catch small things), but it you are happy with the above process then it's all good. I'm only keeping one eye on this and happy to see it moving along so well. Was just surprised my bug was resolved without me first confirming that it actually addressed my issue. 

from mediasession.

foolip avatar foolip commented on July 1, 2024

I think we will reach a point where things are stable enough that we should review each change for typos and such, but not just yet. I'm sure after-the-fact reviews of the diffs would be much appreciated though, and I've done that occasionally.

from mediasession.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.