Comments (7)
WebKit used DeviceOrientationOrMotionPermissionState
. A bit elaborate, but to the point. Any other suggestions?
from deviceorientation.
is there any reason not to re-use PermissionState
as defined in the permission API? I understand prompt
is not a value that would be returned, but since it's in the control of the UA in any case, I'm not sure it matters to have too broad an enum.
from deviceorientation.
Loop in @cdumez to comment on WebKit implementation. @reillyeon for Chromium.
Implementations that ship with permissions.query()
would indeed benefit from enum value prompt
, while WebKit without query()
would still stay compliant with its current implementation even if PermissionState
would be re-used.
from deviceorientation.
I don't really have an opinion here. The name of the enum is not Web-exposed so changing it to whatever would be fine. WebKit does not support for permission API but reusing PermissionState from that spec would equally be fine and would also not require any code change on our side. Note that technically, I copied the Notification API and that one does not use the enum from the Permission API either:
https://notifications.spec.whatwg.org/#enumdef-notificationpermission
It does use a less generic name for the enum though.
from deviceorientation.
Thanks @cdumez for confirming WebKit would be fine with this spec re-using the PermissionState
enum from the Permissions API.
Chromium CL (not merged) defines DeviceOrientationPermissionState
. FYI @rakuco, the proposal in discussion is to add a third state prompt
to the enum.
This issue is now on the F2F agenda.
from deviceorientation.
Discussed at TPAC 2019 F2F. Resolved to adopt the PermissionState enum from the Permissions API specification.
https://www.w3.org/2019/09/19-dap-minutes.html#x15
from deviceorientation.
I've sent #88 to fix this.
from deviceorientation.
Related Issues (20)
- Automatic publishing broken due to Specberus errors HOT 6
- Broken references in DeviceOrientation Event Specification
- Broken references in DeviceOrientation Event Specification
- Remove [NoInterfaceObject] HOT 9
- Add non-normative text describing the current deviceorientationabsolute implementation status
- What is difference with Gyroscope API ? HOT 1
- Add integration with Permissions Policy HOT 7
- Set up automatic Bikeshed compilation HOT 2
- Add integration with the Permissions API HOT 1
- requestPermission() and event handling clarification HOT 10
- DeviceMotion only works once at init and return null value HOT 2
- Update to constructor operations HOT 2
- Need to define the DeviceMotionEvent constructor HOT 2
- Move fingerprintable APIs behind permissions HOT 46
- Device motion sampling frequency HOT 2
- Convert DeviceMotionEventAcceleration/RotationRate to dictionaries HOT 1
- DeviceMotionEvent atttributes can't be null per current IDL HOT 18
- Opposite z-axis for example 7 HOT 9
- Example 9 doesn't match the situation
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from deviceorientation.