Comments (9)
plinss
commented on September 27, 2024
1
It's fine, when Shepherd sees a rename it retracts the test asset with the original name, but copies the history over to the new name, so it doesn't really see the new test as new. Agreed it's a bit confusing but probably not worth fixing at this point.
See https://test.csswg.org/shepherd/testcase/::285c8883ddab/shape-outside-circle-032/ for an example.
from csswg-test.
dbaron
commented on September 27, 2024
Is the problem that the same test is in multiple locations, or that we're using the same filename for different tests?
from csswg-test.
dbaron
commented on September 27, 2024
OK, they're different tests, so I guess I should just increment the numbers on the Mozilla tests to the point where the don't conflict.
from csswg-test.
gsnedders
commented on September 27, 2024
@dbaron byte-for-byte identical files are okay and don't get any warning, hence yeah, they're different tests
from csswg-test.
dbaron
commented on September 27, 2024
Fixed in https://hg.csswg.org/test/rev/285c8883ddab but I'm a little worried about the output:
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-circle-001-ref.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-circle-001.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-circle-002-ref.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-circle-002.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-circle-003-ref.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-circle-003.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-circle-004-ref.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-circle-004.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-circle-005-ref.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-circle-005.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-circle-006.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-circle-007.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-circle-008-ref.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-circle-008.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-circle-009.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-circle-010-ref.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-circle-010.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-circle-011-ref.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-circle-011.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-circle-012.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-circle-013.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-circle-014-ref.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-circle-014.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-circle-015.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-circle-016-ref.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-circle-016.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-circle-017-ref.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-circle-017.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-circle-018-ref.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-circle-018.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-circle-019-ref.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-circle-019.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-circle-020-ref.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-circle-020.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-circle-021-ref.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-circle-021.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-circle-022-ref.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-circle-022.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-circle-023-ref.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-circle-023.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-circle-024-ref.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-circle-024.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-ellipse-001-ref.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-ellipse-001.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-ellipse-002-ref.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-ellipse-002.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-ellipse-003-ref.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-ellipse-003.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-ellipse-004-ref.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-ellipse-004.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-ellipse-005-ref.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-ellipse-005.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-ellipse-006-ref.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-ellipse-006.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-ellipse-007-ref.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-ellipse-007.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-ellipse-008-ref.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-ellipse-008.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-ellipse-009-ref.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-ellipse-009.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-ellipse-010.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-ellipse-011-ref.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-ellipse-011.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-ellipse-012.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-ellipse-013-ref.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-ellipse-013.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-ellipse-014-ref.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-ellipse-014.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-ellipse-015-ref.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-ellipse-015.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-ellipse-016-ref.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-ellipse-016.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-ellipse-017-ref.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-ellipse-017.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-ellipse-018-ref.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-ellipse-018.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-ellipse-019-ref.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-ellipse-019.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-ellipse-020-ref.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-ellipse-020.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-inset-001-ref.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-inset-001.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-inset-002-ref.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-inset-002.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-inset-003-ref.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-inset-003.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-inset-004-ref.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-inset-004.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-inset-005-ref.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-inset-005.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-inset-006-ref.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-inset-006.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-inset-007-ref.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-inset-007.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-inset-008-ref.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-inset-008.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-inset-009-ref.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-inset-009.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-inset-010-ref.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-inset-010.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-inset-011-ref.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-inset-011.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-inset-012-ref.html status changed to 'Retracted'
remote: vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-inset-012.html status changed to 'Retracted'
from csswg-test.
gsnedders
commented on September 27, 2024
@dbaron if I'm not mistaken, that's just Shepherd not realising the tests have simply been moved, and probably only matters when we come to export data from Shepherd if (and only if!) there are any review comments on any of them in Shepherd.
from csswg-test.
gsnedders
commented on September 27, 2024
@dbaron So yeah, I think that's nothing to worry about. Thanks for fixing this!
from csswg-test.
dbaron
commented on September 27, 2024
And fixed on the Mozilla side in https://hg.mozilla.org/integration/mozilla-inbound/rev/6dfad3d738fed02f68223568f8ceb43df5a4e575
from csswg-test.
dbaron
commented on September 27, 2024
My concern about those messages was that Shepherd might have retracted both copies of the tests rather than just the second. Also there wasn't a message about the new test being added, which I would have expected Shepherd to issue.
from csswg-test.
Related Issues (20)
- Split Link header over two lines for cascade-import-002 HOT 1
- Get rid of cyclic tests (border-radius tests) HOT 5
- matchMedia.html uses assert_inherits to test a global property HOT 3
- Move `display:run-in` tests out of CSS2.1 tests? HOT 5
- content-inherit-002 test is wrong? HOT 3
- Some tests are missing in xhtml1/reftest-toc.xht HOT 2
- Travis CI is broken again HOT 5
- Add tests for `new DOMMatrix('none')` HOT 1
- Writing Mode Reftests Anti-Aliasing Failures HOT 8
- Test suite build breaks a caret-color test HOT 10
- [css-ui-3][svg] Is SVGZ support actually mandatory? HOT 3
- Build process misses support files for css-values-3_dev/html/vh_not_refreshing_on_chrome.htm HOT 1
- css-values-3_dev/html/vh_not_refreshing_on_chrome.htm has multiple problems HOT 1
- Multicol tests linking to themselves as references HOT 3
- Test suite build broken HOT 3
- Top level support directory — gratuitous? HOT 1
- clip-path-square-001-ref.svg and clip-path-square-002-ref.svg get lost by the build system HOT 1
- Check for wide Python build in build-css-testsuites.sh HOT 1
- Directories whose name are not shortnames HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from csswg-test.