Giter Club home page Giter Club logo

Comments (14)

vyakymenko avatar vyakymenko commented on July 30, 2024

Hello @redevill,
Sure, you can create a PR with this feature,
Thanks!

from angular-seed-express.

redevill avatar redevill commented on July 30, 2024

Ok, will do, my Guess on procedure:

  1. Make another branch with this feature, off of master.
  2. Check in the new code.
  3. Go to the pull request tab, create new pull request
  4. select my branch in the example comparisons?

This right? Guideline document you would like me to follow?
Thanks
Eti

from angular-seed-express.

vyakymenko avatar vyakymenko commented on July 30, 2024

Hello @redevill ,
Please make a fork and follow this guide.

Some additional info: https://help.github.com/articles/syncing-a-fork/

Thanks!

from angular-seed-express.

redevill avatar redevill commented on July 30, 2024

Will do

from angular-seed-express.

redevill avatar redevill commented on July 30, 2024

Could use a little help. I have it working, with a problem, that is not ideal. There is a section in the config that allows you to specify systemJS and systemBuilder (same config used for both it seems?).

I have made the following spec: name: 'shared/', path: 'dist/tmp/shared/'
The wild card (*) allows system builder to resolve the *.ts files that exist in the tmp folder when it does bundling. However, this same wild card, causes ambiguity in systemJS resolver, as it tries to resolve each entry in two ways. e.g. import { User } from 'shared/interfaces/user.interface'
is resolved as both "shared/interfaces/user.interface" and "shared/interfaces/user.interface.js". The one without the .js fails.

One solution is to change the import to be specific:
import { User } from 'shared/interfaces/user.interface.js'
This is not ideal - especially as older IDE's have problems with the "intellisense" in the typescript environment.

Ideas:

  1. Separate Dev and Prod config, each for SystemJS and SystemBuilder?
  2. Better path / map / package spec that works better?

Thoughts?
Thanks
Eti

from angular-seed-express.

vyakymenko avatar vyakymenko commented on July 30, 2024

Hi @redevill ,
I think that we will remove SystemJS very soon in parent seed. So let's wait with this issue a bit.

from angular-seed-express.

redevill avatar redevill commented on July 30, 2024

Oh cool, what resolver will replace it? Webpack? So I can get familiar with how it works...

from angular-seed-express.

vyakymenko avatar vyakymenko commented on July 30, 2024

There will be Rollup.

from angular-seed-express.

vyakymenko avatar vyakymenko commented on July 30, 2024

I think that we can close this issue. The core is updated and now it's easy to manage client and server code.

from angular-seed-express.

redevill avatar redevill commented on July 30, 2024

Ok... so How do you share an interface, so that a single source file defines this interface for both the client and the server?

from angular-seed-express.

vyakymenko avatar vyakymenko commented on July 30, 2024

Hi @redevill ,

I use something like this: Shared Interface

from angular-seed-express.

redevill avatar redevill commented on July 30, 2024

Wow... how does that resolve in the dist folder? Do you have 2 copies?
When I tried that it did not work, because systemjs / systemjs-builder could not resolve both the relative import references. I also had similar resolution issues at run time.

Thank you, I will give the new code a try, with the above suggestion.

from angular-seed-express.

redevill avatar redevill commented on July 30, 2024

Speaking of new code...
I am still having much trouble with some libraries resolving, with version 6.0.1
Could really use a pointer in the right direction with this... If you could spare the time?
Should I open another issue?
image

Thanks!

from angular-seed-express.

vyakymenko avatar vyakymenko commented on July 30, 2024

Hi @redevil,

I hope that I’ll have some time at weekend and will provide you more details.

from angular-seed-express.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.