Rolling recording file about hrrs HOT 8 CLOSED

Hey @shibaevv! That was indeed the reason I kept *Writer and *WriterTarget classes separate. Let me see if I can spare some time to work on this.

from hrrs.

@shibaevv, if you take a quick look at the contents of the org.apache.logging.log4j.core.appender.rolling package, you will notice how complicated file rotation might get. You need a rotation trigger and strategy with all the bells and whistles. You can't just blindly check prevFileName.equals(fileNamePattern.apply(System.currentTimeMillis())) and commence a rotation. I welcome any well-engineered patches (not just a fix to save the day), but I am really short of time to implement such a relatively big feature myself. I had mentioned about logrotate in README. Didn't it work for you?

from hrrs.

from hrrs.

I think this simple solution will work..
Base64HrrsFilter.java.zip

from hrrs.

Thanks for sharing your solution @shibaevv, but it has two major drawbacks:

1. Filter should not deal with file rotation. It is a responsibility of Writer and WriterTarget classes. (For instance, in Log4j, do you specify/trigger rotation every time you call log.info(...)?)
2. Calling File#length() for every record is [IMHO] unacceptable from performance PoV.

from hrrs.

It was quick temp solution to fix my problem.
I notice you have @see com.vlkan.hrrs.servlet.HrrsFilter#getMaxRecordablePayloadByteCount(), so you can integrate this rolling functionality on overflow event:
if (recordedLenght > getMaxRecordablePayloadByteCount())

from hrrs.

@shibaevv, I have just released a new library: rotating-fos. I will be using this to enhance HttpRequestRecordWriterFileTarget. If you want to give it a try yourself first, go ahead.

from hrrs.

@shibaevv, I have pushed the change and I am about to cut a new release. Please do let me know if it doesn't work for you. (Feel free to re-open the issue.)

from hrrs.