Finding out if a timeout happened about tornado-subprocess HOT 5 CLOSED

Also i found a bug where my callback gets called with one argument [status_code, stdout, stderr] if timed out and gets called with three arguments (status_code, stdout, stderr) if it completed proper.

from tornado-subprocess.

Hi Bernardo,

found it. I'll have an update ready tomorrow. Thanx for the report, glad you find it useful.

Best,
Vukasin

from tornado-subprocess.

What do you think about the change I proposed? It would be very useful to me to find out whether a process timed out instead of it just failing.

from tornado-subprocess.

The change is useful. That's what I was hoping to commit today.

Sent from my iPhone

On 19.12.2012, at 03:30, Bernardo Heynemann [email protected]
wrote:

What do you think about the change I proposed? It would be very
useful to me to find out whether a process timed out instead of it
just failing.

—
Reply to this email directly or view it on GitHub.

from tornado-subprocess.

just checked it in. there are two ways of working with it now

1. inherit from GenericSubprocess where you can override on_timeout and on_finish
2. the callback function takes an additional parameter has_timed_out

from tornado-subprocess.