Comments (8)
I will take care of this.
On a second note, I am trying to rewrite src/api/img.js to use libvips , which is 5x faster (according to their docs) than imageMagik and does not have any system dependencies. Also looking at better image cache instead of using /tmp. Something that supports configurable invalidation and multiple engines. I considered ES as img storage for a while but until ES 6.4, blob storage type is not really worth it.
I am taking my time on this one as I do not have that much time but I think relying on a lib (imagable) that no longer exists (github 404) is a wrong move to begin with.
from vue-storefront-api.
should there not be a fallback for other image libraries, or serve the image not resized if no image libraries are found ?
from vue-storefront-api.
Another solution would be to server the api on a docker instance and set the requirements ourselves,
install the dependencies as needed, which also reduces the access to ES to have a public port mapped
from vue-storefront-api.
You're right. Could you please take care of this (I mean - updating the docs that Imagemagick is required + maybe some warning message in the vue-storefront-api console?)
The fallback would probably require quite a lot of work - so I belive the warning + docs is enough
WDYT @DarkMukke ?
from vue-storefront-api.
Cool, fingers crossed for this!
from vue-storefront-api.
https://github.com/lovell/sharp looks like a good candidate:
- It replaces ImageMagick with https://github.com/jcupitt/libvips which seems faster
- It's a node lib, so we can ditch our current wrapper for ImageMagick (less code)
from vue-storefront-api.
Related to:
vuestorefront/vue-storefront#165
@DavidRouyer Would be great if You can take care of this
from vue-storefront-api.
See #110
from vue-storefront-api.
Related Issues (20)
- "We can't find the page" with url request, but search Vue component works fine
- Validation - Order schema validation is broken
- Add Payment Information endpoint
- Incompatible call Magento 2.1 rest API /rest/V1/products-render-info HOT 1
- Invalid token for guest when tokenInHeader is true
- Could you explain the meaning of the `manage_stock` product field?
- I can not place orders because the API expects a different message from VSF
- Price data on one of configurable_children deleted
- request package has been deprecated
- Tier prices and tier prices customer groups
- Extension API HOT 1
- mailchimp api 404 response HOT 1
- Magento 2 stock.js is inheriting from AbstractUserProxy instead of AbstractStockProxy
- Cache Tags blows up the response header
- uncaughtException: ResponseError: illegal_argument_exception while mage2vs products import
- [FEATURE] Use a Logger to replace console logs
- Mac Os Big Sur - M1 chip docker install error HOT 1
- Magento 2: include "ALL GROUPS" tier prices to all customer groups
- Attributes not being cached in Redis HOT 4
- 500(Internal server on all api's)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vue-storefront-api.