Giter Club home page Giter Club logo

Comments (8)

DarkMukke avatar DarkMukke commented on September 21, 2024 1

I will take care of this.

On a second note, I am trying to rewrite src/api/img.js to use libvips , which is 5x faster (according to their docs) than imageMagik and does not have any system dependencies. Also looking at better image cache instead of using /tmp. Something that supports configurable invalidation and multiple engines. I considered ES as img storage for a while but until ES 6.4, blob storage type is not really worth it.

I am taking my time on this one as I do not have that much time but I think relying on a lib (imagable) that no longer exists (github 404) is a wrong move to begin with.

from vue-storefront-api.

DarkMukke avatar DarkMukke commented on September 21, 2024

should there not be a fallback for other image libraries, or serve the image not resized if no image libraries are found ?

from vue-storefront-api.

DarkMukke avatar DarkMukke commented on September 21, 2024

Another solution would be to server the api on a docker instance and set the requirements ourselves,
install the dependencies as needed, which also reduces the access to ES to have a public port mapped

from vue-storefront-api.

pkarw avatar pkarw commented on September 21, 2024

You're right. Could you please take care of this (I mean - updating the docs that Imagemagick is required + maybe some warning message in the vue-storefront-api console?)

The fallback would probably require quite a lot of work - so I belive the warning + docs is enough

WDYT @DarkMukke ?

from vue-storefront-api.

pkarw avatar pkarw commented on September 21, 2024

Cool, fingers crossed for this!

from vue-storefront-api.

DavidRouyer avatar DavidRouyer commented on September 21, 2024

https://github.com/lovell/sharp looks like a good candidate:

from vue-storefront-api.

pkarw avatar pkarw commented on September 21, 2024

Related to:
vuestorefront/vue-storefront#165

@DavidRouyer Would be great if You can take care of this

from vue-storefront-api.

DavidRouyer avatar DavidRouyer commented on September 21, 2024

See #110

from vue-storefront-api.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.