Giter Club home page Giter Club logo

Comments (3)

pkarw avatar pkarw commented on June 14, 2024

You mean 100 (not 10) correct? yes, i think it could be useful to have it as a config variable; why not

from vue-storefront-1.

benbenek avatar benbenek commented on June 14, 2024

Sorry, my description probably was a bit bad.

Currently it's limited to 10 results per filter in ES by default. But it would be nice to have all available variants in these filters - that's what filters are for, right? ;)

What I've posted above with {size: 100} is just how i've made it work while trying to find the "bug" but this 3rd argument which increases this value to 100 doesn't even exist in the original code.
That's why i suggest to make it configurable in the config.json/local.json...

The Demo-Store "Size"-Filter looks like this in Default Category and is limited to 10 items...

image

But if you open a Product you can see that there exist few more sizes... (e.g. "36" in the following example)

image

from vue-storefront-1.

nuovecode avatar nuovecode commented on June 14, 2024

Same issue here!

there are 2 issues to be discussed:

  • Setting a fixed maximum number of terms for each aggregation doesn't mean that we always have the right number of options for each filter because it depends on the backend. Is it acceptable for you?
  • Setting a number too high (es.100 to be sure) could impact too much on the performances?

I'd like to find a smart way of solving the problem, for example a "more options" link to load ten items a time. I don't know if elastic allows such a thing (load buckets from 1 to 10, then from 10 to 20 etc ..) I'll check.

What were you thinking of doing?

from vue-storefront-1.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.