Giter Club home page Giter Club logo

Comments (5)

Mister-Hope avatar Mister-Hope commented on May 18, 2024 1

Font awesome is supported in 1.7.0.

See https://vuepress-theme.mrhope.site/guide/feature/icon/

from vuepress-theme-hope.

ItsBioDude avatar ItsBioDude commented on May 18, 2024

Hi there, after a few days I realise that there is still another bug (I'm still using FontAwesome)
As you see in the picture below, the icon next to Account rendered different from the original.
Other icon next to Cat, Tags, Timeline have the same issue. They look transparency. I've taken a look and finally realise that sth change from the solid style into regular style (change solid into transparency and add border). Because the fas fa-tag, fas fa-th-large, fas fa-history are 100% solid so they become completely transparency. Would you mind have a look at this? Thanks

image

image

from vuepress-theme-hope.

Mister-Hope avatar Mister-Hope commented on May 18, 2024

Got it, font-weight: 400 is inflecting the apprence:

image
image

from vuepress-theme-hope.

ItsBioDude avatar ItsBioDude commented on May 18, 2024

Well, there is a document about font-weight:
https://fontawesome.com/how-to-use/on-the-web/advanced/css-pseudo-elements

from vuepress-theme-hope.

Mister-Hope avatar Mister-Hope commented on May 18, 2024

Well, there is a document about font-weight:
https://fontawesome.com/how-to-use/on-the-web/advanced/css-pseudo-elements

The problem is that while fontawesome is changing font-weight in different types, iconfont is not setting it's font-weight. But iconfont icons do need a normal(400) font weight to make the icon appearance right. Tags like h1 and other classes in theme have different font-weight, which will affect the icon appearance, that's why I set a default font-weight: 400( the same as font-weight: normal) to the icon in order to ensure the icons have the correct appearance.

I am hoping that the icon class user added have a higher priority. But I forgot users are adding a css link to the final css which will make the classes have a lower priority, which is not what I am expected.

I didnot catch up with a better solution.

Either I remove that style and let all the iconfont users to add that style in their index.styl, or I remain the style and let all the fontawesome users to add the style I list above. It's kind of document thing.

Since more users are using iconfont, I am going to remain the style, and metion users to add extra style when using fontawesome in docs.

If you have any ideas improving the situation, welcome to reply.

from vuepress-theme-hope.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.