Version 4.1.0 Describe the bug <p dir="aut

Memory increase: Update from 4.0.2 to 4.1.0 about vuex HOT 2 OPEN

fallemand commented on June 2, 2024 1

Memory increase: Update from 4.0.2 to 4.1.0

from vuex.

Comments (2)

zcrumbo commented on June 2, 2024 1

For what it's worth, I've also seen a memory leak for an SSR'd Vue app after moving from 4.0.2 to 4.1. Reverting solved the issue.
The heap dump indicated the store was getting persisted in memory for every page render, leading to a very fast OOM crash on the deployed container.

from vuex.

zcrumbo commented on June 2, 2024 1

It seems like this change is what is responsible - the closure seems to be retained on the SSR process

vuex/src/store-util.js

Lines 40 to 58 in d562224

 const computedCache = {} 

 // create a new effect scope and create computed object inside it to avoid 

 // getters (computed) getting destroyed on component unmount. 

 const scope = effectScope(true) 

 scope.run(() => { 

 forEachValue(wrappedGetters, (fn, key) => { 

 // use computed to leverage its lazy-caching mechanism 

 // direct inline function use will lead to closure preserving oldState. 

 // using partial to return function with only arguments preserved in closure environment. 

 computedObj[key] = partial(fn, store) 

 computedCache[key] = computed(() => computedObj[key]()) 

 Object.defineProperty(store.getters, key, { 

 get: () => computedCache[key].value, 

 enumerable: true // for local getters 

 }) 

 }) 

 })

from vuex.

Memory increase: Update from 4.0.2 to 4.1.0 about vuex HOT 2 OPEN

Comments (2)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	const computedCache = {}

	// create a new effect scope and create computed object inside it to avoid
	// getters (computed) getting destroyed on component unmount.
	const scope = effectScope(true)

	scope.run(() => {
	forEachValue(wrappedGetters, (fn, key) => {
	// use computed to leverage its lazy-caching mechanism
	// direct inline function use will lead to closure preserving oldState.
	// using partial to return function with only arguments preserved in closure environment.
	computedObj[key] = partial(fn, store)
	computedCache[key] = computed(() => computedObj[key]())
	Object.defineProperty(store.getters, key, {
	get: () => computedCache[key].value,
	enumerable: true // for local getters
	})
	})
	})