Getters that only update when values have changed about vuex-router-sync HOT 5 OPEN

I'm having this problem too. I have a few getters that do some processing based on the url param/query values but it's triggering even when not being changed.

from vuex-router-sync.

This fork provides the functionality of only pushing updates when values change. https://github.com/lukas-tr/vuex-enhanced-router-sync

from vuex-router-sync.

@urkle Can't you make a PR to vuex-router-sync to fix this issue?

from vuex-router-sync.

Ye this is pretty annoying, the getter should be updated only if the values are different. The issue we have is when we have computed properties that somehow access the anything on the router they are all precomputed although the params are still the same. I believe this should be by default and have an option to behave such forceful way.

from vuex-router-sync.

Totally need this. Even if DOM is not updated because of this, there is quite a lot of unnecessary computation for Virtual DOM.

I've tested something like this mixin, and it works for views. Can something similar be implemented for store getters also, which depend on router store's state?

'use strict';
const _ = require('lodash');

//Expects 'qPsToCache'.
//Adds '$_qpsManager_cachedQPs', which is updated when 'qPsToCache' is truly updated.

module.exports = {
    data() {
        return {
            $_qpsManager_cachedQPs: {}
        }
    },

    watch: {
        qPsToCache(toQPs, fromQPs) {
            if(!_.isEqual(toQPs, fromQPs)) this.$data.$_qpsManager_cachedQPs = toQPs;
        }
    },

    created() {
        this.$data.$_qpsManager_cachedQPs = this.qPsToCache;
    }
};

from vuex-router-sync.