Feature request: respect devtools definition about test-utils HOT 6 CLOSED

Hi @webfansplz !

IIRC we just use the COMPONENT_EMIT event to know if an event has been emitted. I don't think we are tied to an implementation of the devtools: we just subscribe to the events emitted by the framework for the devtools. But maybe I'm misunderstanding what you are looking for?

from test-utils.

Hi @webfansplz !

IIRC we just use the COMPONENT_EMIT event to know if an event has been emitted. I don't think we are tied to an implementation of the devtools: we just subscribe to the events emitted by the framework for the devtools. But maybe I'm misunderstanding what you are looking for?

Hi @cexbrayat !

This is because calling setDevtoolsHook actually overrides the initialization of devtools. See: https://github.com/vuejs/core/blob/HEAD/packages/runtime-core/src/devtools.ts#L52-L53

from test-utils.

Ha OK I understand now 👍

Well TBH, I'm not a fan of adding an option to mount just to test the devtools. Maybe we can find another solution?

from test-utils.

Ha OK I understand now 👍

Well TBH, I'm not a fan of adding an option to mount just to test the devtools. Maybe we can find another solution?

I thought maybe we could add an extra judgment, if globalThis.__VUE_DEVTOOLS_GLOBAL_HOOK__ is already defined (see: https://github.com/vuejs/core/blob/HEAD/packages/runtime-core/src/renderer.ts#L340-L341), we could implement the subscription by overriding its emit method without overwriting the original devtools definition.

from test-utils.

Yeah maybe that could work 👍

from test-utils.

Yeah maybe that could work 👍

Thank you, I'll submit a PR to support it.

from test-utils.