Vue.log proposition about discussion HOT 10 CLOSED

Yeah, this could be pretty handy.

from discussion.

Cool! I'll do a PR when I have some time.

from discussion.

Fiddle here with the implemented code: http://jsfiddle.net/ayamflow/RT7kG/ - waiting to push the PR, it just bothers me that doing Vue.log(vm) will throw an error because of the circular reference.

I'm not sure if I should test each arguments and ignore the ones with circular reference, or just keep it as it is, since it's the expected behavior from JSON.parse.

from discussion.

Bumping this - could @yyx990803 or a more experienced developer than me give me a hint ?
If my implementation is bad or brings weird checks to the codebase, I can make it a plugin instead.

from discussion.

The circular reference comes from vm.$compiler.vm. It might be easier to do a shallow clone and in the process filter out all keys that start with $.

from discussion.

I didn't expect this helper to give me such trouble ahah ! I had some free time tonight so I gave it a go.

I ended up with this, what do you think ? Instead of cloning, I tested if each property passed to the Vue.log method was a vm or a $compiler.

/**
     * Clean log without getter/setter
     * usefull for in-application debugging.
     * Only log $data & its properties
     */
    cleanLog: function() {
        if(!console) return

        var args = [].slice.call(arguments)

        for(var i = args.length - 1; i >= 0; i--) {
            var arg = args[i]
            if(!utils.isTrueObject(arg)) continue

            var hasCircularRef = false,
                isVm = !!arg.$compiler

            // If arg is a vm, log $data directly
            if(isVm) {
                args.splice(i, 1, arg.$data)
                continue
            }

            // don't log if $ or $compiler
            for(var prop in arg) {
                // $compiler
                if(prop === 'vm') hasCircularRef = true
                // $ / v-ref
                if(utils.isTrueObject(arg[prop]) && '$compiler' in arg[prop]) hasCircularRef = true
            }

            if(hasCircularRef) {
                args.splice(i, 1)
                continue
            }
        }
        return console.log.apply(console, JSON.parse(JSON.stringify(args)))
    }

Basically, it will ignore any properties not coming from the $data hash.

It's a bit long for its purpose, but I think all the use cases are covered. I need to add some unit tests to be sure though.

Edit: Check this fiddle to see it working.

from discussion.

Pretty cool! It has grown more complex than I thought too, but maybe this could fit well as a debugging plugin? That way we don't have to include code that won't be used in production and have the flexibility to add more debugging functionalities in the future.

from discussion.

Yep that's what I was thinking !
Thank your for your guidance, much appreciated. I'll make it a plugin when I have some time :)

from discussion.

Here it comes: vue-debug.
Only adding the Vue.log method for now. Hoping people will contribute and add amazing methods !

(I'll tinker with the test runner later this week)

from discussion.

👍

from discussion.