ClickOutside not working on iOS devices about click-outside HOT 13 CLOSED

My first thought are these two segments

It specifies click, but I'd typically have a touch event recognized as well.

const clickHandler = 'ontouchstart' in document.documentElement ? 'touchstart' : 'click';

That would transform those segments to

const clickHandler = 'ontouchstart' in document.documentElement ? 'touchstart' : 'click';
!isServer(vNode) && document.addEventListener(clickHandler, handler) 

const clickHandler = 'ontouchstart' in document.documentElement ? 'touchstart' : 'click';
!isServer(vNode) && document.removeEventListener(clickHandler, el.__vueClickOutside__.handler)

I'm going to be implementing this library and if I run into the same issue, I'll see if this is a proper solution. If it is I'll drop a quick PR in the process!

from click-outside.

@brennenf made the PR 😄

from click-outside.

@trollepierre I have no idea what came of this all.

My PR is still open and ready for merge, but the fix itself can be applied yourself if you need it.

I'm just as in the dark as you are at this point.

from click-outside.

@paquette The above fix worked for me. Thank you.

from click-outside.

Glad to help @brennenf totally forgot about this, I haven't made a PR yet!

from click-outside.

@paquette Actually, if you have the time would you mind making a PR? It would be helpful for project install automation to have the patched version on npm. No worries if not!

from click-outside.

So, is that issue closed?

from click-outside.

😞

from click-outside.

This package looks abandoned. For anyone trying to fix this, try : https://github.com/ndelvalle/v-click-outside, it supports touch events out of the box and was good for my case.

from click-outside.

Yeah it seems like it, I've had an open PR that's received no feedback or sign of merge whatsoever.

#17

I have left the PR open and branch for so long because when I closed it and cleaned up some people emailed me asking where it had disappeared to, was hoping to get this merged sometime before the year 2045 but not looking hopeful at this point 😅

from click-outside.

Sweet, glad this is finally merged.

from click-outside.

Thanks.

from click-outside.

45629f4...v1.1.0
@pqt Published v1.1.0

from click-outside.