Giter Club home page Giter Club logo

Comments (21)

StefH avatar StefH commented on August 16, 2024 2

This is some time ago. I'll see if I can find some time to check my project and upgrade if needed. And also check that NuGet package.

from websocketlistener.

vtortola avatar vtortola commented on August 16, 2024

Yes, give it a try and we can see how difficult would be. There are some dependencies on other assemblies, so I not completely sure it would work out of the box.

from websocketlistener.

LennyPenny avatar LennyPenny commented on August 16, 2024

I unfortunately have no idea how to compile c# packages myself and installing them. Any idea where I could read that up?

from websocketlistener.

vtortola avatar vtortola commented on August 16, 2024

Neither do i :D

from websocketlistener.

pehadavid avatar pehadavid commented on August 16, 2024

hey,

dnx support will be definitely great ! I can do it, but it will require large modifications (including in the sln structure).
Here's the main approach :

  • changing every csproj to xproj (with just dnx451 support)
  • checking that the classic dotnet platform support is not broken
  • adding dnxcore 5.0 support

Tell me what you think

from websocketlistener.

vtortola avatar vtortola commented on August 16, 2024

Would that somehow break compatibility with VS2013 and .NET 4.5.1 ?

from websocketlistener.

pehadavid avatar pehadavid commented on August 16, 2024

I don't know if VS2013 support xproj project. But it will not break .net 4.5.1 support.

from websocketlistener.

vtortola avatar vtortola commented on August 16, 2024

I am going to be incredibly busy until Xmas. I can create a new branch and we can experiment there, however if you need my support I cannot guarantee that will happen straight away :( But definitely sounds interesting and I want to at least try 👍

Would that suit you?

from websocketlistener.

pehadavid avatar pehadavid commented on August 16, 2024

An experimental branch would be nice ;)
Thanks !

from websocketlistener.

pehadavid avatar pehadavid commented on August 16, 2024

I have good news. I tried to implement dotnet core support, and it went well.
you can check it on my forked repo. (here : https://github.com/papci/WebSocketListener).

If you want to check if it's compatible with VS2013, feel free to do it :)

Thanks.

from websocketlistener.

StefH avatar StefH commented on August 16, 2024

I've forked from papci and added support for more frameworks:

  • net45, net451 and net452
  • dnx451 and dnx451
  • dnxcore5

And i was able to compile dnxcore5 on Linux, however the UnitTest project cannot compile/run because Moq is not present for dnxcore5. (Maybe also nunitlite has some issues.)

from websocketlistener.

vtortola avatar vtortola commented on August 16, 2024

I still have to take a look to the changes that @papci did (sorry, i had busy Xmas :( )

@StefH do you have the code somewhere?

from websocketlistener.

StefH avatar StefH commented on August 16, 2024

Code is present in my branch (which was forked from papci)

https://github.com/StefH/WebSocketListener

from websocketlistener.

vtortola avatar vtortola commented on August 16, 2024

Sorry I have been trying to find free time to take a look at this and due some personal committments I just can't :( I see you guys are doing progress. I will try to follow up and in the meantime please reach me for any question you may have about the standard code. Thanks!

from websocketlistener.

StefH avatar StefH commented on August 16, 2024

dotnet rc2 support --> netstandard 1.3
See pull request:
#65

from websocketlistener.

Supergeek avatar Supergeek commented on August 16, 2024

Considering the difficulty of importing DLLs into Core, it would be greatly appreciated if someone would publish one of their Core-compatible forks to Nuget.

from websocketlistener.

vtortola avatar vtortola commented on August 16, 2024

Hi, I think @StefH already did some work on this https://www.nuget.org/packages/vtortola.WebSocketListener.dnx/2.2.0.1-beta-00002

from websocketlistener.

StefH avatar StefH commented on August 16, 2024

I've updated the project again to latest netstandard.

Initial NuGets are created and pushed to myget.org : https://www.myget.org/F/websocketlistener/api/v3/index.json

Please try.

I'll create a PR later (I've tried to keep the changes/differences minimal, but I'll have some discussions with @vtortola on that I guess...)

from websocketlistener.

deandob avatar deandob commented on August 16, 2024

Hi, do post when these dotnet core changes are merged back in the main branch and available. Thanks for the time spent on this.

from websocketlistener.

StefH avatar StefH commented on August 16, 2024

Code is merged to main. However some work is needed. See also #93

from websocketlistener.

vtortola avatar vtortola commented on August 16, 2024

Done un 3.0.0

from websocketlistener.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.