Giter Club home page Giter Club logo

Comments (17)

VPenkov avatar VPenkov commented on June 30, 2024

I'm unsure how okayNav acts around CommonJS but that's at the top of my to-do list.

from okaynav.

dingo-d avatar dingo-d commented on June 30, 2024

Did you look into the clash with revolution slider? I am trying to figure out what could be the issue, but I really have no idea what could cause it. Their code is minimzed, and all I see is that the issue is here:

    T = function(t, i, a) {
        i.syncload--,
        i.loadqueue && e.each(i.loadqueue, function(e, i) {
            var n = i.src.replace(/\.\.\/\.\.\//gi, "")
              , o = self.location.href
              , r = document.location.origin
              , s = o.substring(0, o.length - 1) + "/" + n
              , l = r + "/" + n
              , d = k(self.location.href, i.src);
            o = o.substring(0, o.length - 1) + n,
            r += n,
            (_(r) === _(decodeURIComponent(t.src)) || _(o) === _(decodeURIComponent(t.src)) || _(d) === _(decodeURIComponent(t.src)) || _(l) === _(decodeURIComponent(t.src)) || _(s) === _(decodeURIComponent(t.src)) || _(i.src) === _(decodeURIComponent(t.src)) || _(i.src).replace(/^.*\/\/[^\/]+/, "") === _(decodeURIComponent(t.src)).replace(/^.*\/\/[^\/]+/, "") || "file://" === window.location.origin && _(t.src).match(new RegExp(n))) && (i.progress = a,
            i.width = t.width,
            i.height = t.height)
        }),
        C(i)
    }

from okaynav.

VPenkov avatar VPenkov commented on June 30, 2024

I replied to your email, please check your spam folder from Tue, Mar 1, 2016, around 8:25 PM GMT +2.

I'll post the solution in the docs when we figure out what's wrong.

from okaynav.

dingo-d avatar dingo-d commented on June 30, 2024

Stupid google, I've replied to the mail. Hope you'll find the issue. I've tried moving the scripts in footer, in header, made okayNav dependent on revolution slider, nothing helped. And without destroying it and enabling it on resize I still get the errors and menu doesn't go back to original menu (mobile -> desktop).

I'll try to see what else could be the issue.

from okaynav.

cognopatrick avatar cognopatrick commented on June 30, 2024

Came up with the same problem, you guys found a solution?

from okaynav.

dingo-d avatar dingo-d commented on June 30, 2024

Nope, I don't know why the revolution slider clashes with the navigation (don't really see where the clash could come from). So I removed the okayNav and started to work on my own custom nav. Try removing the touch based events all together (even though I have disabled them). That's the only thing that comes to mind that could clash with rev slider.

from okaynav.

cognopatrick avatar cognopatrick commented on June 30, 2024

okay guys, few day's later. Anyone found a solution? Need to get this website up and running 😄

from okaynav.

VPenkov avatar VPenkov commented on June 30, 2024

I'm in contact with Themepunch. Hopefully I'll be provided with a demo license to ensure compatibility.
Meanwhile if anyone is okay with giving me access to their website where I can perform tests, drop me a line at [email protected]

from okaynav.

VPenkov avatar VPenkov commented on June 30, 2024

Can any of you guys tell me if the problem still persists with the current version?
Seems like a CommonJS issue which should be resolved now.

from okaynav.

cognopatrick avatar cognopatrick commented on June 30, 2024

updated revolution slider to Version: 5.2.3 but the problem is not resolved. Stil the same errors, the strange thing is that te slider acts normal but load time is extremely long and console errors accure:

Uncaught TypeError: $ is not a function 3jquery.themepunch.revolution.min.js?ver=5.2.3:8 Uncaught TypeError: Cannot read property 'href' of undefined jquery.themepunch.revolution.min.js?ver=5.2.3:8 http://hotelvillaflora.nl/wp-content/uploads/2016/03/drinking.jpg Could not be loaded !(anonymous function) @ jquery.themepunch.revolution.min.js?ver=5.2.3:8n.extend.each @ jquery.min.js?ver=1.10.2:2n.fn.n.each @ jquery.min.js?ver=1.10.2:2waitForCurrentImages @ jquery.themepunch.revolution.min.js?ver=5.2.3:8(anonymous function) @ jquery.themepunch.revolution.min.js?ver=5.2.3:8 jquery.themepunch.revolution.min.js?ver=5.2.3:8 http://hotelvillaflora.nl/wp-content/uploads/2016/03/ribbon-slider.png Could not be loaded !(anonymous function) @ jquery.themepunch.revolution.min.js?ver=5.2.3:8n.extend.each @ jquery.min.js?ver=1.10.2:2n.fn.n.each @ jquery.min.js?ver=1.10.2:2waitForCurrentImages @ jquery.themepunch.revolution.min.js?ver=5.2.3:8(anonymous function) @ jquery.themepunch.revolution.min.js?ver=5.2.3:8 jquery.themepunch.revolution.min.js?ver=5.2.3:8 http://hotelvillaflora.nl/wp-content/uploads/2016/03/button-bekijk-het-menu.png Could not be loaded !(anonymous function) @ jquery.themepunch.revolution.min.js?ver=5.2.3:8n.extend.each @ jquery.min.js?ver=1.10.2:2n.fn.n.each @ jquery.min.js?ver=1.10.2:2waitForCurrentImages @ jquery.themepunch.revolution.min.js?ver=5.2.3:8(anonymous function) @ jquery.themepunch.revolution.min.js?ver=5.2.3:8

Also my own written jquery gives errors with revolution slider..

from okaynav.

dingo-d avatar dingo-d commented on June 30, 2024

I had errors and the image wasn't showing.

from okaynav.

cognopatrick avatar cognopatrick commented on June 30, 2024

Do you also stil have these issues?

from okaynav.

VPenkov avatar VPenkov commented on June 30, 2024

I meant that you should update okayNav to the latest version.

What theme are you using? There's surely something I'm missing here and need to replicate locally.

from okaynav.

cognopatrick avatar cognopatrick commented on June 30, 2024

I build my own theme, ill take a look at updating

from okaynav.

cognopatrick avatar cognopatrick commented on June 30, 2024

I updated okaynav and revolution slider but without any changes. Still the same problem

from okaynav.

dingo-d avatar dingo-d commented on June 30, 2024

I had to find a different solution so I had to abandon the okayNav unfortunately.

from okaynav.

abdulrauf618 avatar abdulrauf618 commented on June 30, 2024

@dingo-d I was facing same issue.
Image exists on server but in

jquery.themepunch.revolution.min.js

imgLoaded = function(e, i, t) {

giving an error of undefined href

after few seconds giving a warning

Could not be loaded !

I fixed it,
Solution: update image load function

imgLoaded = function(e, i, t) {
                i.syncload--, i.loadqueue && jQuery.each(i.loadqueue, function(i, a) {
                var n = a.src.replace(/\.\.\/\.\.\//gi, "");
                var r = (self.location != undefined ) ? self.location.href : n;
                var o = document.location.origin,
                    s = r.substring(0, r.length - 1) + "/" + n,
                    l = o + "/" + n;
                    var d = abstorel(r, a.src);
                r = r.substring(0, r.length - 1) + n, (cutParams(o += n) === cutParams(decodeURIComponent(e.src)) || cutParams(r) === cutParams(decodeURIComponent(e.src)) || cutParams(d) === cutParams(decodeURIComponent(e.src)) || cutParams(l) === cutParams(decodeURIComponent(e.src)) || cutParams(s) === cutParams(decodeURIComponent(e.src)) || cutParams(a.src) === cutParams(decodeURIComponent(e.src)) || cutParams(a.src).replace(/^.*\/\/[^\/]+/, "") === cutParams(decodeURIComponent(e.src)).replace(/^.*\/\/[^\/]+/, "") || "file://" === window.location.origin && cutParams(e.src).match(new RegExp(n))) && (a.progress = t, a.width = e.width, a.height = e.height)
            }), progressImageLoad(i)
        },

from okaynav.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤ī¸ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.