MSVS2017: C1091 string exceeds 65535 bytes in length about nginx-module-sts HOT 6 CLOSED

Thanks for suggesting it.
I fixed it.
Please test if the C1091 occur when compiling in the latest commit.

Latest commit: 9d5c74e

from nginx-module-sts.

Some issues:

• sizeof("123") != sizeof( char[] {'1','2','3'} ) - did you forget about NULL term in char string?
  (as I see you calc size of array in ngx_http_stream_server_traffic_status_display.c:360)
• VS use precompiled headers, so every .c file must contains #include <ngx_config.h> at the top
• also uninitialized key.data, so add key.data = NULL; after ngx_http_stream_server_traffic_status_display.c:646

and after that it look like ok.

from nginx-module-sts.

OK, you are right. 😆
I fixed it.

1. added NULL into char array.
2. included ngx_config.h into ngx_http_stream_server_traffic_status_module.h and ngx_http_stream_server_traffic_status_string.c files. (Please check if an compile error occurs.)
3. initialized key variable by ngx_memzero().

Please test.
Latest commit: 391a4de

from nginx-module-sts.

2. PCH feature only work when include added to every .c file (not .h), so now i cant build without modifications..

from nginx-module-sts.

OK, I added it.
Please check it.
FYI. I'm just curious. Is it possible to disable pre-compiled headers feature when compiling?

Latest commit: a5d65d0

from nginx-module-sts.

Yeah, now all ok.

Yes, you can disable using PCH using -Y* options (see here), but by default nginx configure script generate makefile with -Yu:

....
objs/ngx_modules.obj:	$(CORE_DEPS) \
	objs/ngx_modules.c
	$(CC) -c $(CFLAGS) -Yungx_config.h -Fpobjs/ngx_config.pch $(ALL_INCS) \
		-Foobjs/ngx_modules.obj \
		objs/ngx_modules.c
....

File ngx_modules.c contains references to all modules: kernel and that was added with --add-module args (when you call configure.sh).
So, by default nginx build use precompiled headers when compile via MSVC.

from nginx-module-sts.