Giter Club home page Giter Club logo

Comments (10)

jairojunior avatar jairojunior commented on July 28, 2024

Can you check if this solution fixes your problem? https://ask.puppetlabs.com/question/16629/installing-puppet-lint-to-pe-error-provider-gem-is-not-functional-on-this-host/

Never happened to me. Which OS are you using?

from puppet-wildfly.

ltutar avatar ltutar commented on July 28, 2024

[root@wildflyagent ~]# cat /etc/release
CentOS Linux release 7.1.1503 (Core)
Derived from Red Hat Enterprise Linux 7.1 (Source)
NAME="CentOS Linux"
VERSION="7 (Core)"
ID="centos"

from puppet-wildfly.

jairojunior avatar jairojunior commented on July 28, 2024

Archive/faraday dependency removed.

from puppet-wildfly.

smbambling avatar smbambling commented on July 28, 2024

@jairojunior: What was the reasoning behind removing the support for deploying from nexus ? Is that just a part of removing the requirement for the archive module?

This is something that we use pretty heavily as nexus provides an easy method for storing and obtaining specific version of a artifact (war).

Is there consideration for adding this feature back in ?

from puppet-wildfly.

jairojunior avatar jairojunior commented on July 28, 2024

@smbambling It's better to give module users freedom to use whichever module they need to manage downloads.

You should still be able to use:

archive::nexus { '/tmp/MyApp.ear': }

wildly::deployment { 'MyApp.ear':
  source => '/tmp/MyApp.ear'
} 

It's not that bad, right?

from puppet-wildfly.

smbambling avatar smbambling commented on July 28, 2024

@jairojunior I think I might see a few issues...

  1. The local_source variable is not configurable...and dumping items into the /tmp dir can be removed on a system if they are not referenced in X days. That would cause it to be refetched
  2. If the source is a local path on the file system a wget is still executed which causes an issue
 smbambling@icinga  ~  touch bambling.txt
 smbambling@icinga  ~   wget -N -P /tmp /home/smbambling/bambling.txt --max-redirect=5
/home/smbambling/bambling.txt: Scheme missing.
  1. Also not sure...but it would seem that the file_name variable is going to be incorrect if a local source is set to a file system path. I'm unaware of how the URI::parse will handle that.

Over all though I think your suggestion of just fetching the war independently is 100% valid and workable.

from puppet-wildfly.

jairojunior avatar jairojunior commented on July 28, 2024

@smbambling Thank you, I'll review wildfly::deployment according to your suggestions.

Regarding your 'not sure' point, it will work even with file:://. You'll only have problems if you don't have file name in the URI, and it happens if you're querying a service for a file (e.g. Nexus HTTP API). We could use --content-disposition (http://superuser.com/questions/301044/how-to-wget-a-file-with-correct-name-when-redirected) for this cases.

from puppet-wildfly.

smbambling avatar smbambling commented on July 28, 2024

@jairojunior:

In place of using the wget with --content-disposition. What about just checking the URI scheme to make sure its valid for wget

╰─ irb
2.2.3 :001 > require 'uri'                                                                                                                                                                                                                    
 => true
2.2.3 :002 > uri = URI.parse("http://www.google.com")
 => #<URI::HTTP http://www.google.com>
2.2.3 :003 > uri.scheme
 => "http"
2.2.3 :004 > uri = URI.parse("/tmp/foo.war")
 => #<URI::Generic /tmp/foo.war>
2.2.3 :005 > uri.scheme
 => nil
2.2.3 :006 > uri = URI.parse("https://www.google.com")
 => #<URI::HTTPS https://www.google.com>
2.2.3 :007 > uri.scheme
 => "https"
2.2.3 :008 > uri = URI.parse("ftp://www.google.com")
 => #<URI::FTP ftp://www.google.com/>
2.2.3 :009 > uri.scheme
 => "ftp"
2.2.3 :010 >

from puppet-wildfly.

smbambling avatar smbambling commented on July 28, 2024

@jairojunior Also ...maybe a new issue should be created to track this ?

from puppet-wildfly.

jairojunior avatar jairojunior commented on July 28, 2024

@smbambling Sure. Currently, wildfly::deployment and wildfly::config::module only support ftp, http and https protocols. And as we discussed its definitely need file support.

from puppet-wildfly.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.