Comments (3)
Hi!
I thought a bit about this. If you set active
to true
on the systemd::unit_file
defined resources, it creates the service resource for you:
https://github.com/camptocamp/puppet-systemd/blob/8f68b0dcf3bbbafc60c025879a28004fc9815aab/manifests/unit_file.pp#L91-L98
You basically define the service twice, once in your profile and once via the defined resource. This works by accident because the defined resource references the service with send_downtime.service
and the profile with send_downtime
. This means that you could shorten the profiles:
class profile::monitoring {
systemd::unit_file { 'send_downtime.service':
content => file('profile/send_downtime.service'),
active => true,
enable => true,
}
}
class profile::base_os {
systemd::unit_file { 'remove_check_mk_cache.service':
content => file('profile/remove_checkmk_cache.service'),
active => true,
enable => true,
}
}
While this is shorter, it indeed creates the dependency loop you mentioned. On a few of my profiles I workaround this by not ordering the profiles like you did in your role. I set explicit dependencies in my profile to resources to the other profiles. In your case that would mean:
class profile::monitoring {
systemd::unit_file { 'send_downtime.service':
content => file('profile/send_downtime.service'),
active => true,
enable => true,
}
Service['remove_check_mk_cache.service'] -> Service['send_downtime.service']
}
class profile::base_os {
systemd::unit_file { 'remove_check_mk_cache.service':
content => file('profile/remove_checkmk_cache.service'),
active => true,
enable => true,
}
}
But I understand that ordering profiles in a role is a common pattern and I do that myself alot as well. In that case just remove the active => true,
line from your two systemd::unit_file and all works as well.
from puppet-systemd.
Fix is available in #171
from puppet-systemd.
#171 has been merged so I think this can be closed now.
from puppet-systemd.
Related Issues (20)
- manage_unit service_entry Environment can't have multiple values HOT 3
- Running the example code for `systemd::manage_unit` from REFERENCE.md causes an error:
- Add possibility to setup limits for user sessions HOT 6
- IODeviceWeight, IOReadIOPSMax, .. do not work in systemd::manage_unit or systemd::dropin_file HOT 1
- Missing parameters under Service section HOT 2
- Provide possibility to disable service restart upon unit file change
- Add hiera-friendly option to manage dropins HOT 2
- Add `NetworkNamespacePath` to unit service HOT 4
- Allow specifying multiple Environment variable HOT 2
- Usage of `systemd::escape` in `systemd::timer_wrapper` creates weird names HOT 7
- [4.1.0] ignore active+enable when ensure is set to absent for systemd::timer HOT 1
- Issue with hiera since v 7.0.0 HOT 2
- systemd::user_service broken for puppet running in background HOT 3
- Deprecation of systemd::service_limits unexpectedly causes service restarts in some scenarios HOT 7
- Add support for systemd link files HOT 2
- Allow systemd unit specifiers in path values HOT 2
- Setting default_target fails due to deprecated shell_escape function HOT 2
- Inconsistent values for `notify_service` in replacement for `systemd::service_limits` HOT 1
- udev rules not reloaded after change
- Unit file path inconsistency HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from puppet-systemd.