Comments (6)
nanliu
commented on September 25, 2024
I'm not sure the root cause for the first one, but sounds similar to this post: https://groups.google.com/forum/#!msg/puppet-users/zXpgBB9cZgE/3h1aSJvCNKgJ
The second might be addressed by #25. Sorry the Windows feature/PR is not something I'm able to review very well since it's not a platform I use/test. I'll trust the collective input from @reidmv and other users.
from puppet-staging.
reidmv
commented on September 25, 2024
#25 does address the second error.
For the first error, yes, we should probably remove the mode parameter when operating on Windows. I'll submit a pull request shortly. Talking to Josh Cooper about whether or not it would be best to leave everything undef or explicitly set owner/group using well-known (static) SIDs to Administrators / Local System. PR will happen once I get that figured out.
from puppet-staging.
planet
commented on September 25, 2024
@nanliu @reidmv sounds good guys, i'll keep an eye out for any updates to address the issues. thanks for the attention on the matter..
from puppet-staging.
reidmv
commented on September 25, 2024
I've created a branch at https://github.com/reidmv/puppet-module-staging/compare/fix_windows_mode. I haven't had time to test it, but if it works I think it's the way to go.
from puppet-staging.
nanliu
commented on September 25, 2024
Tested and merged #33.
from puppet-staging.
jumanjiman
commented on September 25, 2024
@nanliu @reidmv Thanks for getting this in
from puppet-staging.
Related Issues (20)
- Syntax error in staging_windir.rb HOT 8
- Failure to set '::staging::path' HOT 2
- Duplicate resource declaration HOT 8
- Add deprecation notice to README
- Add an opts parameter for tar HOT 2
- Deprecate this module in favour of puppet/archive HOT 4
- source_permissions in file.pp is raising a deprecation warning HOT 4
- Remove staged file after deploy HOT 1
- Variable $path not correctly scoped HOT 1
- staging extract with rename HOT 1
- Staging Deploy to take strip parameter HOT 1
- Puppet 4 support HOT 4
- staging module can create 0 length files HOT 1
- File source using https with username/password fails with certain password character sequences HOT 1
- unzip should use -o -f always or optionally HOT 2
- Ability to validate checksum and/or file size of archive HOT 1
- Release to puppet-community namespace on forge HOT 3
- Error loading staging_windir.rb HOT 7
- JSON syntax in staging_windir fact causes syntax error using Ruby 1.8 HOT 2
- Path not fully qualified (Windows) HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from puppet-staging.