Comments (11)
Could you set in hiera yaml file to control the jre/jdk version? With this way, you can control the version by yourself, even to install rundeck with java 8.
jre_name
The name of the jre to be installed if using a custom jre.
from puppet-rundeck.
Sure, it can be done either in Hiera or as a resource-style class declaration with the parameter; doesn't change the fact that the hard-coded default is no longer current.
I'm undecided about whether trying to track versions like this is a good idea or not -- on the one hand, it requires maintaining a version compatibility mapping that will require maintenance; on the other hand, it's really great for things to just work out of the box.
But resolving that is someone else's call; since it's there now, it should be correct.
from puppet-rundeck.
My view for this issue is, it is not issue.
Many sites are still using rundeck version of 1.5.X and 1.6.X, update to java 7 is not 100% correct.
from puppet-rundeck.
We should be able to support this without breaking backwards compatibility with people running with older versions.
I do think that it's important to continue to support to most basic use-case where everything works out of the box.
from puppet-rundeck.
our jira, stash and confluence modules have established a pattern for tracking the version through facts. (this makes upgrades really easy)
so if we do add a version compat matrix to this module, we should also track the installed version.
from puppet-rundeck.
I saw the new open pull request which have a lot of code changes.
But why make it so unnecessary complicated
and spend time on it. The comments in manifests/init.pp
has explained how to install rundeck with a custom jre. It is the end user who should know which java version should be installed with Rundeck.
# Installing rundeck with a custom jre:
#
# class { 'rundeck':
# jre_name => 'openjdk-7-jre',
# jre_version => '7u51-2.4.4-0ubuntu0.12.04.2'
# }
from puppet-rundeck.
So you think it would be better to make those required parameters and bump a major version?
from puppet-rundeck.
@liamjbennett
That's my personal option. As my first reply, this issue is not issue from my view.
commits wcooley@4d9ba11 and wcooley@db406a1 have been merged, looks reasonable.
But commit 5b304fe goes too far away, it adds function, but not necessary.
from puppet-rundeck.
I have raised an alternative PR for this issue - that completely removes the management of the JRE.
The argument is this case is that it should probably be managed at the profile level and just documented in this module as a dependency.
Thoughts?
from puppet-rundeck.
I think not managing the JRE is probably fine - it's a big, messy piece that has lots of other interested parties, so leaving it up to the user is probably for the best. It would be a good idea (I haven't looked at your PR) to include externally managing the JRE in the examples (maybe using puppetlabs/java) -- that will make it more visible than just including it in a body of text.
from puppet-rundeck.
Removed the management of the JRE. Need to add many more examples into the documentation anyway before the next release but I will raise that as a separate PR.
Closing this issue now as it is no longer relevant. Thanks for pushing me forward to deal with this problem.
from puppet-rundeck.
Related Issues (20)
- What about a new module release? HOT 3
- secrets / keys are not stored in the database when using rundeck::key_storage_type: db
- How to: rundeck.storage.provider.'1'.type = 'vault-storage'
- Incorrect configuration key for threadcount HOT 2
- rundeck project type/provider
- on VMWare, UUID is created in framework.properties that is overwritten by rundeck
- Support for Rundeck 3.3.x HOT 3
- Release v7.0.0 without CentOS 6 support!
- a colon is added to realm.properties file even when auth_users hash is empty
- Support for Rundeck >3.3.10
- Module doesn't support apt-key through proxy HOT 1
- Rundeck 3.4 no longer supports the rundeck.projectsStorageType configuration property
- Deprecate Bintray and use the newer repositories
- Re-release required HOT 1
- Add sensitive option for database_config HOT 5
- RSpec error if used with inifile >= 4.2.0
- Missing rundeck.security.syncLdapUser config setting HOT 1
- ACLs render incorrectly when using attributes filters
- Please update dependent modules to allow for their latest versions
- manage SCM configuration of projects HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from puppet-rundeck.