r10k::webhook::config provides support for changing config file path, but the webhook script has this hardcoded about puppet-r10k HOT 6 CLOSED

Is this something you wanted to do, or just something you noticed in the code?

I have a branch, but want to get a feeling if there is a rational for wanting this or if its just that I should not expose that var.
https://github.com/acidprime/r10k/compare/webhook_updates?expand=1

from puppet-r10k.

I discovered the issue when I tried to put the webhook settings in /etc/r10k-webhook.yaml instead of /etc/webhook.yaml, my reasoning being that this way I could avoid any potential collisions with other webhook services. In practice, I'm not actually using any other webhook services and probably won't be, so it's not a huge priority that this be a possibility. That being said, it might be a good idea to just rename the webhook to r10k-webhook or something.

from puppet-r10k.

thats a pretty major change so I will likely leave renaming until 3.x , that said, do you have examples of this in the wild?

from puppet-r10k.

Nope. Entirely speculation on my part.

from puppet-r10k.

closing this for now, can reopen as need if the community requests it

from puppet-r10k.

I would at least for now recommend removing the configfile parameter on r10k::webhook::config in the meantime, as all it does is break the webhook.

from puppet-r10k.