Giter Club home page Giter Club logo

Comments (4)

brutus333 avatar brutus333 commented on September 26, 2024

I was hit by this issue when using the module to upgrade prometheus & friends. scrape_configs is useful only initially or if you plan to configure prometheus only by puppet; which is not always the case.

I agree with your proposal. Can you please make a PR?

from puppet-prometheus.

Cosaquee avatar Cosaquee commented on September 26, 2024

I have prometheus.yml file with more than 10 jobs so it is not convenient to keep it in pp files.

I will fork this and make a PR.

As I can see you still have Ruby 1.9.3 in your Travis tests. From my experience i can say that it is really hard to maintain Puppet modules with this Ruby version. It is really hard to make sure that dependencies are correct without doing some really ugly things in Gemfile.

Have you considered dropping support for 1.8.7 and 1.9.3 ?

from puppet-prometheus.

lobeck avatar lobeck commented on September 26, 2024

Isn't this fixed by #25?

from puppet-prometheus.

Cosaquee avatar Cosaquee commented on September 26, 2024

@lobeck I looks like #25 is exactly what i wanted. I will close this issue and thanks for you PR : )

from puppet-prometheus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.