Comments (4)
I was hit by this issue when using the module to upgrade prometheus & friends. scrape_configs is useful only initially or if you plan to configure prometheus only by puppet; which is not always the case.
I agree with your proposal. Can you please make a PR?
from puppet-prometheus.
I have prometheus.yml
file with more than 10 jobs so it is not convenient to keep it in pp files.
I will fork this and make a PR.
As I can see you still have Ruby 1.9.3 in your Travis tests. From my experience i can say that it is really hard to maintain Puppet modules with this Ruby version. It is really hard to make sure that dependencies are correct without doing some really ugly things in Gemfile.
Have you considered dropping support for 1.8.7 and 1.9.3 ?
from puppet-prometheus.
Isn't this fixed by #25?
from puppet-prometheus.
@lobeck I looks like #25 is exactly what i wanted. I will close this issue and thanks for you PR : )
from puppet-prometheus.
Related Issues (20)
- node_exporter.pp does not provide direct way to override the listening port
- ipmi exporter does not support remote ipmi HOT 1
- Add support for managing kafka node exporter
- deprecation of `source_match(_re)` and `target_match(_re)`
- mongodb_exporter doesn't allow overriding service and binary name
- Trouble using prometheus::server::collect_tag. HOT 1
- node_exporter change default port 9100 HOT 2
- Support scrape_config_files option HOT 3
- Received SIGTERM, exiting gracefully HOT 3
- Remove prometheus 1.x support
- Remove support for alertmanager < 0.13.0
- Drop support for redis_exporter < 1.0.0
- "job_name: prometheus" duplication HOT 1
- replace systemd unit templates with systemd::manage_unit
- Dependency Dashboard
- Dependency Dashboard
- Drop suppoprt for apache_exporter < 1.x HOT 1
- move all exporter versions to the manifests.
- Drop support for elasticsearch_exporter < 1.1.0
- Archlinux prometheus server ui bug with version > 15
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from puppet-prometheus.