Affected Puppet, Ruby, OS and module versions/distributions <li

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

thanks <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-u

bug: alert rules are still 1.0 syntax for Prometheus 2 about puppet-prometheus HOT 5 CLOSED

voxpupuli commented on June 24, 2024

bug: alert rules are still 1.0 syntax for Prometheus 2

from puppet-prometheus.

Comments (5)

tuxmea commented on June 24, 2024

@knackjax can you provide an example how the alert rules must be for prometheus2? Can you also provide a PR?

from puppet-prometheus.

costela commented on June 24, 2024

@tuxmea https://prometheus.io/blog/2017/06/21/prometheus-20-alpha3-new-rule-format/

I'm also taking a look at this, but if someone beats me to a PR, all the better! 😉

from puppet-prometheus.

costela commented on June 24, 2024

Ideally, we'd support both formats, and maybe also take the chance and fix #69 while we're at it.

from puppet-prometheus.

knackjax commented on June 24, 2024

I have a hack for this, which basically uses promtool to update to 2.0 syntax. We are just evaluating prometheus for our needs right now if we adopt it we will try to submit a cleaner solution

    exec { "promtool update ${alertfile_name}":
        user        => $user,
        group       => $group,
        command     => "${bin_dir}/promtool update rules ${config_dir}/${alertfile_name}",
        require     => [
            Package[$package_name],
            File["${config_dir}/${alertfile_name}"]
        ],
        unless      => "/usr/bin/test -f ${config_dir}/${alertfile_name}.yml",
        subscribe   => File["${config_dir}/${alertfile_name}"]
    }
    # ensure file was created
    file { "${config_dir}/${alertfile_name}.yml":
        ensure       => 'file',
        owner        => $user,
        group        => $group,
        validate_cmd => "${bin_dir}/promtool check rules ${config_dir}/${alertfile_name}.yml",
    }

from puppet-prometheus.