Ubuntu 16.04: using backwards-compatible default setting chroot=y about puppet-postfix HOT 9 CLOSED

@lelutin if the module was a new one, I'd say we should be as close as possible to the OS standard. However because this module already has a history which is to set chroot to false by default, I think we should keep it backwards-compatible.

from puppet-postfix.

So you're suggesting we should use false for Ubuntu 16.04?

from puppet-postfix.

i honestly don't know
it's really complicated, or, else depends on whether you wanna keep compatibility with the module or the software

from puppet-postfix.

Yes. I'd rather the module behave in a standard manner as much as possible.

from puppet-postfix.

Maybe you could include PR #170 that adds a parameter to configure chroot. If you leave it undefined, the it uses the software default (- in master.cf ) but you could also force it to true (y) or false (n).
But the PR is failing because of problems, I think that not directly related with the PR, building ubuntu machines for CI.

from puppet-postfix.

@igalic would #224 fix this bug?

from puppet-postfix.

hello! from what I can see, #224 changes the default value of $chroot to false for all distributions.

debian uses chrooted daemons by default (which postfix upstream is not too happy about, but that's another story)

so the solution here depends on you goals towards how things are managed:

if you'd like for the puppet module to have default settings that are as close as possible to distro defaults, then you could special-case the value of the $chroot parameter in the params class.

however, if you want to simplify and/or standardize how the module manages default configuration, then #224 does this well.

In all cases, the undef value to $chroot seems useless after the change, so it'd probably be nice to add a deprecation warning and remove it at some later point to keep only 'y' and 'n' as possible values.

from puppet-postfix.

@raphink this makes a lot of sense!

from puppet-postfix.

Merged #224 which makes all chroot options default to false as it's always been in this module.

from puppet-postfix.