Giter Club home page Giter Club logo

Comments (11)

KlavsKlavsen avatar KlavsKlavsen commented on September 25, 2024

I had to, manually, remove GATEWAY setting in /etc/sysconfig/network-scripts/ifcfg-ethX - and then the default network_route works as expected.
Setting the ip for eth0 interface with network_config - didn't even remove the GATEWAY setting.

Oddly enough, the other routes now works as well:

192.168.63.0    0.0.0.0         255.255.255.0   U     0      0        0 eth0
169.254.0.0     0.0.0.0         255.255.0.0     U     1002   0        0 eth0
192.168.0.0     192.168.63.1    255.255.0.0     UG    0      0        0 eth0
10.0.0.0        192.168.63.1    255.0.0.0       UG    0      0        0 eth0
0.0.0.0         192.168.63.50   0.0.0.0         UG    0      0        0 eth0

(I rebooted once more).

from puppet-network.

adrienthebo avatar adrienthebo commented on September 25, 2024

Thanks for reporting this!

Looking at https://access.redhat.com/site/documentation/en-US/Red_Hat_Enterprise_Linux/6/html/Deployment_Guide/s1-networkscripts-static-routes.html , it seems like the format for the routes should be valid; if I'm understanding you correctly then the routes did start working?

The documentation also says that you can add a default route of the format default via X.X.X.X dev interface; is the problem that GATEWAY was added to the file and then not removed later? Were you managing the interface file with the network_config type?

With respect to not applying the configuration immediately, I've left that up to users to handle. Restarting networking is something that you can't get wrong - if Puppet was restarting the network each time a route was updated it's entirely possible that the machine could get knocked offline. Since it's a bit risky, I've opted to not manage that and let end users do what best suits them. Does that make sense?

from puppet-network.

gwarf avatar gwarf commented on September 25, 2024

Hi,
The format is not valid, when using IP commands arguments format, the netmask should be specified using CIDR notation:

10.8.0.0/24 via 172.20.8.1 dev eth1

Instead of

10.8.0.0/255.255.255.0 via 172.20.8.1 dev eth1

If not the network init script returns an error:

Bringing up interface eth1:  Error: an inet prefix is expected rather than "10.8.0.0/255.255.255.0".
Error: an inet prefix is expected rather than "10.8.1.0/255.255.255.0".

And the module is always removing the CIDR notation from the route, even when setting netmask to 24.

from puppet-network.

gwarf avatar gwarf commented on September 25, 2024

Hi,
I managed to get this working using the changes mentionned in #58.

from puppet-network.

confiq avatar confiq commented on September 25, 2024

I can confirm it's working well...
It's been one year and half and nobody merge this

from puppet-network.

adrienthebo avatar adrienthebo commented on September 25, 2024

@confiq if the pull request worked for you, could you update the pull request with tests and rebase it so that it can be merged?

from puppet-network.

confiq avatar confiq commented on September 25, 2024

@adrienthebo: are we talking about PR #62 ?
It's not mine PR so I can't rebase it but if needed I can make new PR.
About tests, It passes all tests so I don't see a problem merging it. Unless you want to write tests for new check new CIDR notations

CC @gwarf

from puppet-network.

adrienthebo avatar adrienthebo commented on September 25, 2024

A new PR would be fine; I'm fine with merging code to fix this issue but the existing PR has merge conflicts. Since there is a behavior change, it does need tests before it gets merged.

from puppet-network.

adrienthebo avatar adrienthebo commented on September 25, 2024

And if @gwarf is willing to continue working it then superb, but if that doesn't work out I'm happy to accept PRs from other locations.

from puppet-network.

confiq avatar confiq commented on September 25, 2024

Ok,
I've been using HEAD version and it's working fine.
I can't confirm this bug anymore.

from puppet-network.

igalic avatar igalic commented on September 25, 2024

okay, thank you @confiq!

from puppet-network.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.