Giter Club home page Giter Club logo

Comments (3)

jhoblitt avatar jhoblitt commented on September 25, 2024

Here's some thoughts on a possible [simple] implementation of vlan support into network_config.

  • add a new boolean parameter to the network_config type called vlan; an alternative possibility would be add some sort of parameter to declare the type of the interface. Eg. raw|bond|bridge|vlan
  • the debian & redhat providers would both need to be modified to parse the namevar and or the device name into a raw interface name part and a vlan ID part, if the vlan parameter is true.
  • in the redhat provider the "vlanness" of an interface could be be detected by either parsing the filename directly or the device variable in the per interface configuration. It seems that perhaps parsing the device variable would be slightly simpler, only requiring a small hook in parse_file instead of having to build two separate lists of files. If it was desired to validate the format of the files being parsed, it might be easier to do it the other way around and track the name of the file that was parsed to valid the device var in general. No modification of format_file/etc. should be necessary if we are requiring the vlan param on the type to be set.
  • in the debian provider the Instance.initialize method looks like a good place to parse the name into raw & vlan tagged components. format_file would need to be modified to inject the vlan-raw-device line.

Thoughts/comments/criticisms?

from puppet-network.

jhoblitt avatar jhoblitt commented on September 25, 2024

Off issue discussed with @adrienthebo has resulted in the conclusion that it makes more sense to add a parameter to set the type of interface that's being configured. eg, vlan|bridge|bond as these states seem to be mutually exclusive, at least under the linux kernel.

from puppet-network.

jyaworski avatar jyaworski commented on September 25, 2024

Hello:

What's the status of this issue? I'm just pinging old issues. Is this possibly related to #98?

from puppet-network.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.