Giter Club home page Giter Club logo

Comments (6)

jlambert121 avatar jlambert121 commented on May 26, 2024

dirname does exist in stdlib, but not in the 3.x series (only in 4.x). Currently PE only supports the 3.x series so we can't reliably use the dirname function. Your solution would work for this - would you be able to send a PR?

from puppet-jenkins.

matthewbarr avatar matthewbarr commented on May 26, 2024

Looks like 4.x is supported by PE, but they might need to manually update. 4.x is still compatable with Puppet 2.7, despite original plans..

might be worth considering, sooner or later..

from puppet-jenkins.

jlambert121 avatar jlambert121 commented on May 26, 2024

Awesome - what versions of PE support 4?

Maybe we put this in as a post 1.0? Make the next version require stdlib >= 4.0?

from puppet-jenkins.

matthewbarr avatar matthewbarr commented on May 26, 2024

v3.0.x (Released in PE 3)
v4.0.x (Maintains compatibility with v3.x despite the major semantic version bump. Compatible with Puppet 2.7.x)
(from https://github.com/puppetlabs/puppetlabs-stdlib )

However, it doesn't ship with PE 3, so.. yeh.

I don't have PE, but i don't know if it breaks if you update PE's stdlib to a newer verison than it ships with.

from puppet-jenkins.

jlambert121 avatar jlambert121 commented on May 26, 2024

A couple guys said you can't upgrade it (PL and former) with PE because of how tightly it's coupled, that's why I was curious what version. My thinking was the same as yours - puppet is supported, go for it.

That being said, I think for this either the inline_template or leave it as it is solutions are the most portable. I can do this later if the OP doesn't have time.

from puppet-jenkins.

rtyler avatar rtyler commented on May 26, 2024

I'm pretty sure this can be closed with the merge of #102

from puppet-jenkins.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.