Some plugins not updating about puppet-jenkins HOT 9 CLOSED

Any potential dependency change?

from puppet-jenkins.

No, not as far as I can see. I'll check next time I'm with this client (next week now).

Thanks,

R.

from puppet-jenkins.

I'm experiencing this same issue.

from puppet-jenkins.

This happens for core plugins. See https://wiki.jenkins-ci.org/display/JENKINS/Plugin+tutorial#Plugintutorial-Deployingacustombuildofacoreplugin

from puppet-jenkins.

This kind of makes me wonder if we should add a .pinned to each plugin managed by puppet. That would resolve this (I think) and also ensure things defined by puppet are as puppet says.

from puppet-jenkins.

Fixed this issue by changing:

--- a/manifests/plugin.pp
+++ b/manifests/plugin.pp
@@ -78,7 +78,7 @@ define jenkins::plugin(

     file { "${plugin_dir}/${plugin}" :
       require => Exec["download-${name}"],
-      owner   => 'jenkins',
+      owner   => 'root',
       mode    => '0644',
       notify  => Service['jenkins'],
     }

from puppet-jenkins.

tobias-m: Thank you, that worked!

But I'm struggling to see why ...

File["${plugin_dir}/${plugin}"] requires that Exec["download-{$name}"] is executed before it, which does a rm -rf ${name} ${name}.* && wget --no-check-certificate ${base_url}${plugin}.

As I read the code, the rm deletes both the plugin folder and any file starting with the plugin name (such as swarm.hpi or ldap.jpi), and the wget downloads the new .hpi file for the plugin. After this, Service['jenkins'] is notified, and the plugin folder is populated by Jenkins.

Now, why would it have an impact who (root in your fix, otherwise jenkins) owns this .hpi file prior to the Jenkins service being notified (I assume restarted)?

from puppet-jenkins.

This is overriding what jenkins is trying to do with the hpi file. By default, jenkins wants to own and control all of the core modules. Changing the owner to root prevents the jenkins user from managing the file the way it wants to. I imagine there's an empty catch block in the code that's keeping this from blowing up completely. I think the better solution is to add a .pinned file for each core module that jenkins manages. See #131.

from puppet-jenkins.

I believe this issue should be resolved by #389 so I'm going to close this issue. Please reopen it if the problem is reproducible with the current master.

from puppet-jenkins.