Giter Club home page Giter Club logo

Comments (13)

solarkennedy avatar solarkennedy commented on May 24, 2024

Cool. I've released 0.4.6 to the forge and added a compatibility section.

The next version/tag of this module will be 0.5.0 to be compatible with Consul 0.5.0!

from puppet-consul.

solarkennedy avatar solarkennedy commented on May 24, 2024

Believe it or not, this module does have an acceptance test suite, I would love to see us TDD our way towards 0.5.0 compatibility.

from puppet-consul.

EvanKrall avatar EvanKrall commented on May 24, 2024

These sound like they could cause us to be backwards-incompatible. Should we bother maintaining a branch that's compatible with 0.4, or just expect people to upgrade?

from puppet-consul.

solarkennedy avatar solarkennedy commented on May 24, 2024

Na. If people are on .4 they can use a release from the .4 series, otherwise they can be on .5 or master.

from puppet-consul.

centromere avatar centromere commented on May 24, 2024

Has there been any progress towards 0.5.0?

from puppet-consul.

solarkennedy avatar solarkennedy commented on May 24, 2024

Na :(

from puppet-consul.

jelmerk avatar jelmerk commented on May 24, 2024

Any ETA on when a 0.5.0 compatible version will be released?

from puppet-consul.

solarkennedy avatar solarkennedy commented on May 24, 2024

There is #94, but needs a little TLC.
Patches welcome?

from puppet-consul.

hopperd avatar hopperd commented on May 24, 2024

Do you have a list of additional known items that need to make this compatible? I'd be happy to provide some pull requests.

from puppet-consul.

solarkennedy avatar solarkennedy commented on May 24, 2024

As far as I know, the list at the top of this issue is it. For the most part things are backwards compatible, but I'm not running 5.0 in production yet.

from puppet-consul.

hopperd avatar hopperd commented on May 24, 2024

I added a pull request #98 with the additional options for checks along with unit tests for it. I will work on the additional service options as well.

from puppet-consul.

hopperd avatar hopperd commented on May 24, 2024

I went ahead and finished up the service portions and move all the validation logic into a function since it needed to really be used in multiple locations by consul::check and consul::service with the checks array. The pull request is located #99.

I added several tests to ensure that things are getting handled properly but please double check to see if anything was missed or more tests are wanted.

from puppet-consul.

solarkennedy avatar solarkennedy commented on May 24, 2024

This in place.
I'm not using .5 in production yet, so we'll have to wait for bug reports if anything crucial is missing.

from puppet-consul.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.