config_hash converts strings to integers => breaks port mappings about puppet-consul HOT 6 CLOSED

Yea, we explicitly try to "cast" these into ints for service:
https://github.com/solarkennedy/puppet-consul/blob/master/manifests/service.pp#L49

Then we do it on a bit more keys here:
https://github.com/solarkennedy/puppet-consul/blob/master/manifests/config.pp#L82-L98

I'm... up for suggestions?

We could take a advantage of the fact that we have a custom function to write the json down:
https://github.com/solarkennedy/puppet-consul/blob/master/lib/puppet/parser/functions/consul_sorted_json.rb

In ruby we could look at each key, and if it looks like an int, make it an int?
Seems a little dangerous, but a tad better than whitelisting keys?

from puppet-consul.

Something like this?

irb(main):001:0> iffy_integers = [-1, '+1', '-goats', 'moats-', '8500', '2+3', '-3454', '-this is A-']
=> [-1, "+1", "-goats", "moats-", "8500", "2+3", "-3454", "-this is A-"]

irb(main):002:0> iffy_integers.map { |i| (i.kind_of?(String) and i.match(/\A[-]?[0-9]+\z/)) ? i.to_i : i }
=> [-1, "+1", "-goats", "moats-", 8500, "2+3", -3454, "-this is A-"]

from puppet-consul.

Yea, that looks like it achieves the desired effect.
@aj-jester want me to whip that into a PR or did you want to?

from puppet-consul.

@solarkennedy #156

from puppet-consul.

@weitzj this should be fixed on the latest master thanks to @aj-jester

from puppet-consul.

Thank you. :)

from puppet-consul.