Request: Varnish plugin about puppet-collectd HOT 13 CLOSED

Would you be willing to submit a pull request?

from puppet-collectd.

I am in the process of making a plugin; will only support varnish 3 though as v2 had issues with system libraries and collectd requiring manual building

Sent from my iPhone

On Jan 17, 2014, at 6:37 PM, William Van Hevelingen [email protected] wrote:

Would you be willing to submit a pull request?

—
Reply to this email directly or view it on GitHub.

from puppet-collectd.

Sounds good

from puppet-collectd.

I have the plugin written, but it doesn't appear to install the required package. How would I go about doing that? In the previous plugins I've written the packages are already installed with collectd. I've looked over the apache plugin, but it isn't obvious how it requests the package installation.

from puppet-collectd.

Are you referring to varnish or a collectd varnish plugin package? If the latter add a package resource in the class. I'm guessing the apache one doesn't handle that case.

from puppet-collectd.

The collectd-varnish package. I will add the declaration; the interesting part will be potentially different package names across package managers. Thanks!

Sent from my iPhone

On Jan 21, 2014, at 12:24 PM, William Van Hevelingen [email protected] wrote:

Are you referring to varnish or a collectd varnish plugin package? If the latter add a package resource in the class. I'm guessing the apache one doesn't handle that case.

—
Reply to this email directly or view it on GitHub.

from puppet-collectd.

Make sure to add the package name in params.pp so we can handle it across multiple platforms.

from puppet-collectd.

In unbutu, it comes in collectd-core ... how would you prefer the check on this? A conditional in the varnish.pp checking on $::osfamily? What are the thoughts about including the os name in the collected::params to is can be accessed via collectd::params::osname?

from puppet-collectd.

Hmm collectd-core doesn't seem very plugin specific how do the other platforms behave?

from puppet-collectd.

From my understanding, collectd-core includes the vast majority of plugins, but I don't have an ubuntu box to test on (I guess I could spin one up...); RHEL/CentOS/Fedora use collectd-< plugin_name > i.e. collectd-varnish.

However, I just ran into an issue that I've spent most of the day resolving. collectd-varnish crashes collectd version 5.3.1. Installing collectd 5.4.0 resolves the issue so I will have to make it a dependency to the plugin; at least for RHEL flavors.

from puppet-collectd.

It appears this plugin may have to be put on hold for official release as most repos do not have a 5.4.0 package for collectd or collectd-varnish yet. I can build some, but it doesn't do anyone else any good.

from puppet-collectd.

You can submit the pull request without the package support and we can worry about the packages later.

from puppet-collectd.

PR submit with package support; willing to remove it and resubmit.

from puppet-collectd.