Setting collectd::plugin::nginx params does not work for booleans about puppet-collectd HOT 6 CLOSED

Ok... Boolean are quite badly handled here...

furthermore the default of this option changed in collectd 4.6.0

The only solution I see here is to replace "undef" by the sanest default for that kind of usage (which is "true"). This sane default is also the current default for collectd >= 4.6.0, so we'll be coherent with the documentation of the most recent version of collectd.

Once this default set, we could remove the if close in the template. What do you guys think ?

from puppet-collectd.

as a side note i'm also dubious about why the string "false" gets interpreted as a boolean. That may be the root issue in fact

from puppet-collectd.

I tried both setting the value as a string and as a boolean, no joy on either.

from puppet-collectd.

The approach used in #201 might solve our issue here

from puppet-collectd.

FWIW, the way I handle "tri-state bools" (true/false/undef) is like so:

define foo (
  $foo = undef
) {
  $foo_bool = str2bool($foo)
}

and then in template code:

<% if [email protected]? %>
  foo = <%= @foo ? 'true' : 'false' %>
<% end %>

this has the added benefit of normalizing boolean values on input to what the output should be. str2bool is from puppetlabs/stdlib, but that's ok since it's already used by this module :)

from puppet-collectd.

I edited the last comment, sorry about that. I had typed up my old approach and realized that it was my old approach :)

from puppet-collectd.