Giter Club home page Giter Club logo

Comments (9)

nanliu avatar nanliu commented on September 26, 2024

The other two define types use a function because the checksum file needs processing. The archive parameter checksum_source was intended for this, but not yet implemented. I think checksum_url might be a better name?

from puppet-archive.

jairojunior avatar jairojunior commented on September 26, 2024

@nanliu If you're working with a remote source (http, ftp, s3), checksum_url is probably a better name.

from puppet-archive.

nanliu avatar nanliu commented on September 26, 2024

@jairojunior please review latest changes and provide feedback if you run into any issues. Also I'm happy to take a PR for a define type wrapper for nexus.

from puppet-archive.

nanliu avatar nanliu commented on September 26, 2024

Sorry didn't mean to close issue. Per last comment, I will accept a nexus define type wrapper. I'll list it as experimental along with the go/artifactory wrapper in the readme.

from puppet-archive.

jairojunior avatar jairojunior commented on September 26, 2024

Thank you.

I was able to finish archive::nexus with the latest changes, but I have a small concern about performance.

Check this gist: https://gist.github.com/jairojunior/071a5256abeb1d39e54a

In the second run, with HTTP checksum URL it tooks 12s, with HTTPS, 6s, and hardcoded checksum only takes 0.4s

I have a module that uses net/http to query a HTTP API and the request are really fast (~100ms). Do you have any idea of what is causing this?

Meanwhile, I'll work on rspec tests for archive::nexus.

from puppet-archive.

nanliu avatar nanliu commented on September 26, 2024

I'm not able to reproduce the difference (hardcode v.s. checksum_url difference is negligible for multiple runs). Can you time curl to the url in comparison:
https://gist.github.com/nanliu/0d3f5bf4a53431f81ed2

from puppet-archive.

jairojunior avatar jairojunior commented on September 26, 2024

My bad, it's something with my puppetlabs/centos-6.6-64-puppet vagrant setup:

time curl -i -X GET 'https://oss.sonatype.org/service/local/artifact/maven/content?g=io.hawt&a=hawtio-web&v=1.4.36&p=war.md5&r=releases'

Took 5.5s there and only 0.4s in my machine

puppet apply --debug --trace --profile site.pp --modulepath '/home/jjunior/wildfly-vagrant/deploy/modules'

Is doing fine, less than a second.Thanks again.

from puppet-archive.

jairojunior avatar jairojunior commented on September 26, 2024

@nanliu I think we should close this issue.

from puppet-archive.

nanliu avatar nanliu commented on September 26, 2024

Fix by #54

from puppet-archive.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.