Comments (11)
The setup.sh script is missing a description at the top illustrating how it should be called, what arguments should be passed to it.
from actions.
Can you explain what this is doing?
if [[ ${INPUT_BRANCH} ]]; then # user overwrite
branch="${INPUT_BRANCH}"
elif [[ ${GITHUB_REF} = refs/pull/*/merge ]]; then # pull request
branch="${GITHUB_BASE_REF}"
elif [[ ${GITHUB_REF} = refs/heads/* ]]; then # branch, e.g. stable
branch=${GITHUB_REF#refs/heads/}
elif [[ ${GITHUB_REF} = refs/tags/* ]]; then # tag or release
branch=${GITHUB_REF#refs/tags/}
else
die "Handling on GITHUB_REF=${GITHUB_REF} not implemented"
fi
You are checking if the branch is a valid branch, and also allowing a user to override what branch to use if it is passed in as an option to setup.sh?
from actions.
These die commands could probably be a little more helpful
[[ ${module} ]] || die "Could not fetch module"
Could not determine module from CMakeLists.txt file, no project(votca-....) found
die "Unknown INPUT_TOOLCHAIN"
die "Unknown INPUT_TOOLCHAIN ${INPUT_TOOLCHAIN}"
from actions.
What is the purpose of this:
if [[ ${INPUT_MODULE} = true ]]; then
cmake_args+=( -DMODULE_BUILD=ON -DCMAKE_INSTALL_PREFIX=$HOME/votca.install )
else
cmake_args+=( -DCMAKE_INSTALL_PREFIX=/usr )
fi
from actions.
Can you just a make a PR?
from actions.
The setup.sh script is missing a description at the top illustrating how it should be called, what arguments should be passed to it.
https://github.com/votca/actions/blob/master/setup/action.yml#L3-L41
from actions.
Can you explain what this is doing?
if [[ ${INPUT_BRANCH} ]]; then # user overwrite branch="${INPUT_BRANCH}" elif [[ ${GITHUB_REF} = refs/pull/*/merge ]]; then # pull request branch="${GITHUB_BASE_REF}" elif [[ ${GITHUB_REF} = refs/heads/* ]]; then # branch, e.g. stable branch=${GITHUB_REF#refs/heads/} elif [[ ${GITHUB_REF} = refs/tags/* ]]; then # tag or release branch=${GITHUB_REF#refs/tags/} else die "Handling on GITHUB_REF=${GITHUB_REF} not implemented" fi
You are checking if the branch is a valid branch, and also allowing a user to override what branch to use if it is passed in as an option to setup.sh?
We are figuring out what base branch to use for votca/votca and other checks, e.g. some CMake options only work on the stable
branch.
from actions.
What is the purpose of this:
if [[ ${INPUT_MODULE} = true ]]; then cmake_args+=( -DMODULE_BUILD=ON -DCMAKE_INSTALL_PREFIX=$HOME/votca.install ) else cmake_args+=( -DCMAKE_INSTALL_PREFIX=/usr ) fi
If we are doing a module build, install stuff in a different prefix. The module builds installs stuff in the build step and as we don't run the build with sudo
it needs to be in $HOME
.
from actions.
Can you just a make a PR?
For the trivial changes.
from actions.
Is this still relevant? @junghans
from actions.
Are you guys happy with the documentation now?
from actions.
Related Issues (1)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from actions.